Skip to content

reqwest-client -> reqwest-blocking-client - #171

Merged
OpsBotPrime merged 2 commits into
masterfrom
jerbaroo-reqwest-blocking-client
Aug 19, 2026
Merged

reqwest-client -> reqwest-blocking-client#171
OpsBotPrime merged 2 commits into
masterfrom
jerbaroo-reqwest-blocking-client

Conversation

@jerbaroo

Copy link
Copy Markdown
Contributor

Tested by copilot:

Diagnosis confirmed by reproduction. I built with reqwest-client (current master) and ran the server with OTEL_EXPORTER_OTLP_ENDPOINT
set:

 thread 'OpenTelemetry.Traces.BatchProcessor' (152196) panicked at .../core/src/ops/function.rs:250:5:
 there is no reactor running, must be called from the context of a Tokio 1.x runtime

Note the thread name: OpenTelemetry.Traces.BatchProcessor — the dedicated std::thread with no Tokio runtime, exactly as predicted.

Your change fixes it. Same binary, same env, with reqwest-blocking-client: runs to the timeout with zero panics. Verified via cargo tree
that opentelemetry-otlp now resolves reqwest-blocking-client and no longer reqwest-client

@jerbaroo
jerbaroo requested a review from ReinierMaas August 19, 2026 10:07

@ReinierMaas ReinierMaas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for finding and fixing.

@jerbaroo

Copy link
Copy Markdown
Contributor Author

@OpsBotPrime merge and tag

jerbaroo and others added 2 commits August 19, 2026 13:52
Approved-by: jerbaroo
Priority: Normal
Auto-deploy: false
@OpsBotPrime

Copy link
Copy Markdown
Contributor

Rebased as 41c30ff, waiting for CI …

@OpsBotPrime

Copy link
Copy Markdown
Contributor

CI job 🟡 started.

@OpsBotPrime
OpsBotPrime force-pushed the jerbaroo-reqwest-blocking-client branch from 0697336 to 41c30ff Compare August 19, 2026 12:00
@OpsBotPrime

Copy link
Copy Markdown
Contributor

@jerbaroo I tagged your PR with v62. Please wait for the build of 41c30ff to pass and don't forget to deploy it!

@OpsBotPrime
OpsBotPrime merged commit 41c30ff into master Aug 19, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants