fix(ios): preserve the system More tab appearance - #588
Open
thiagobrez wants to merge 1 commit into
Open
thiagobrez wants to merge 1 commit into
thiagobrez wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
When UIKit inserts More for overflowing tabs, the library styles it using the next route's index. In Six Tabs on iPhone Duo landscape, More consequently looks and reads as Fifth, obscuring access to the overflow destinations.
Preserve the system More item's title, accessibility label, and icon by excluding its identity from route-specific appearance updates. The same guard applies to deferred updates and later appearance changes.
How to test?
Verified with agent-device 0.20.10 and Xcode 27.1 beta / iOS 27.1. Native build and lint pass. Workspace tests and typecheck pass on the same upstream base; this PR changes Swift only.
Screenshots
03-overflow-before-mislabeled.mp4
03-overflow-after-more.mp4