fix(ios): deliver long presses on modern tab bars - #587
Open
thiagobrez wants to merge 1 commit into
Open
thiagobrez wants to merge 1 commit into
thiagobrez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Long presses on modern iOS tab bars select a tab but do not deliver the expected
tabLongPressevent. Their buttons live outside the legacyUITabBarhierarchy, and UIKit expands and duplicates them during its native hold animation.Observe touches from the tab controller's view, recognize modern and legacy tab buttons, and capture the route when the touch begins. Resolve vertical and horizontal order (including RTL), ignore the system More destination, and allow UIKit's gestures to continue. Reuse the recognizer while refreshing its callback.
Fixes #573.
How to test?
Open Native Bottom Tabs from Chat and hold Article for one second. Its callback changes the label to New Article. Verify normal Chat selection still works and Contacts still prevents selection.
Verified with agent-device 0.20.10 on:
Native Xcode build and lint pass. Workspace tests and typecheck pass on the common upstream base. UIKit tab-button class inspection remains an implementation dependency, as in the previous recognizer.
Screenshots
02-long-press-before-no-callback.mp4
02-long-press-after-callback.mp4