fix(ios): initialize bottom accessory Fabric props - #586
Open
thiagobrez wants to merge 1 commit into
Open
thiagobrez wants to merge 1 commit into
thiagobrez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Opening the Bottom Accessory View example aborts in Fabric because
RCTBottomAccessoryComponentViewcreates default props without assigning them to_props. Initialize_propsbefore mounting the accessory.How to test?
Verified with agent-device 0.20.10. Xcode build,
yarn lint,yarn typecheck, andyarn testpass.Screenshots
01-accessory-before-crash.mp4
01-accessory-after-mount.mp4
The separate content-overlap issue remains visible in these recordings and is outside this crash fix.