chore(core): drop unused bytes and byteorder dependencies (LAB-6345) - #82
Conversation
Neither crate is referenced anywhere in the crate. Remove them from the manifest and lockfile, along with the cargo-vet exemption and import that only they used.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: cachekit-io/cachekit-core/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe manifest no longer lists the ChangesDependency and supply-chain entries
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change removes two unused dependencies and a related supply-chain exemption. It should not change runtime behavior. Confirm that the lockfile update and vet import cleanup are in the final commit set, and that the build passes. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Revert an unrelated crossbeam-epoch import that cargo vet added while regenerating imports.lock.
|
@kody review --force |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Summary
Removes the unused
bytes(1.5) andbyteorder(1.5) crates from the unconditional[dependencies]section ofCargo.toml, along with the "Byte utilities" comment block. Neither crate is referenced by the crate's code, so the dependency tree gets smaller and the betaunused_dependencieslint no longer warns about them.Changes
Cargo.toml: Deletes thebytesandbyteorderentries. These were non-optional and applied to every target and feature set, so they are removed from all builds, including native, wasm32, and FFI.supply-chain/config.toml: Removes the[[exemptions.bytes]]entry (version1.11.1,safe-to-deploy). The crate is no longer in the dependency graph, socargo vetdoes not need the exemption. No other vet exemptions or criteria change in this file.Public API Impact
None. No exported types, functions, or feature flags change. The crypto dependencies (
aes-gcm,aes,getrandom) and the native-onlyringtarget dependency are untouched.Notes
Cargo.tomlandsupply-chain/config.toml. TheCargo.lockupdate and the removal of thebyteordervet import described in the existing summary do not appear in the provided patches. Confirm that both are included in the final commit set.bytesorbyteorderbeing pulled in transitively through this crate must now declare them directly. Nothing in the diff shows such a dependency.This PR removes two unused dependencies from
cachekit-core.Changes
Cargo.toml: Removesbytes(1.5) andbyteorder(1.5), along with their "Byte utilities" comment, from the general[dependencies]section.supply-chain/config.toml: Removes thecargo-vetexemption forbytesversion1.11.1(safe-to-deploy), since the crate is no longer a direct dependency. Nobyteorderexemption was present, so none is removed.Impact
Summary by CodeRabbit