Improved imports. - #144
Conversation
| @@ -1,5 +1,4 @@ | |||
| import { update } from '@/routes/vaults'; | |||
| import { children } from '@/routes/vaults/nodes'; | |||
There was a problem hiding this comment.
btw, I haven't done this so must've been some from composer* commands?
| $attributes['name'] = $pathInfo['filename']; | ||
| $attributes['extension'] = $pathInfo['extension'] ?? 'md'; | ||
| $attributes['content'] = (string) file_get_contents("/$file"); | ||
| $attributes['content'] = (string) file_get_contents($file); |
There was a problem hiding this comment.
Windows failed on test without it
| $replacementLinkPath = $node->ancestorsAndSelf()->get()->last()->full_path; | ||
| } | ||
| /** @var string $replacementLinkPath */ | ||
| $replacementLinkPath ??= $node->ancestorsAndSelf()->get()->last()->full_path; |
|
Cześć my polish friend! Hope you're doing well. I have to document the dev environment for sure. So many things to do and so little free time. I'm on vacations. I will try to review this next week ok? Thank you! |
Hola :D yes, thank you.
Would be helpful, I'm not too much into laravel etc, so I don't know how to test it properly :D (there's some missing parts, from
No problem. take your time & enjoy vacation! 🥂 |
2 participants
Hello, I can't test if it works, but I tried... (after like 100's of ssh commands, fixing disabled php extensions on my side:
sqlite3,pdo_sqlite,sockets,intl,zip- were not mentioned in contributing :D), 1 test failing on windows thus I changed"/$file"to$fileetc etc, still can't figure out, how to properly setup dev. (ended up with some reverb? errors). or in consoleapp-CofSMmhW.js:90 You must pass your app key when you instantiate Pusher.. Hours & hours of debugging.But anyway, I have refactored some of the
import(s)to useindex.ts, seems cleaner/shorter, and I just hope it works. @brufdev. 🙏