add voice flavors to lingua - #459
Ken Jiang (knjiang) wants to merge 3 commits into
Conversation
Ken Jiang (knjiang)
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fcaef5263
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| let voice_endpoint = match spec.flavor { | ||
| ModelFlavor::Realtime => Some("/realtime"), | ||
| ModelFlavor::Live => Some("/live/sessions"), | ||
| _ => None, |
There was a problem hiding this comment.
When a realtime/live catalog entry has an equivalent non-voice fallback_models entry and the caller supplies fallback aliases, this per-candidate check rejects the requested voice spec, but resolve_provider_routes_for_failover catches that error and continues until the non-voice spec returns a valid HTTP route. The request therefore bypasses the intended WebSocket-only rejection and may be sent to a semantically incompatible completion endpoint; validate the originally requested model's flavor before expanding equivalent routes, or restrict fallback traversal to the same voice flavor.
AGENTS.md reference: AGENTS.md:L17-L19
Useful? React with 👍 / 👎.
2 participants
No description provided.