fix: add evaluation flavor to ModelFlavor enum - #458
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
I think we can just add the type now and then fill in the actual lingua changes once we are ready |
Ken Jiang (knjiang)
approved these changes
Sep 17, 2026
The shared model catalog (proxy model_list.json) now includes jev-* models with "flavor": "evaluation" (braintrust-proxy #1267). The Rust ModelFlavor enum only knew chat/completion/embedding/responses, so deserializing the catalog failed with `unknown variant "evaluation"`, panicking gateway/api-rs startup. Add the Evaluation variant. No exhaustive matches on ModelFlavor exist, so this is additive. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Erin McNulty (erin2722)
force-pushed
the
gk/add-evaluation-flavor
branch
from
September 17, 2026 17:01
6ca69da to
df5fef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shared model catalog (
proxymodel_list.json) now includes TypeSafejev-*models with"flavor": "evaluation", added in braintrustdata/braintrust-proxy#1267. The RustModelFlavorenum only knewchat/completion/embedding/responses, so deserializing the catalog fails withunknown variant "evaluation", panicking gateway/api-rs startup.This adds the
Evaluationvariant so the shared catalog deserializes.Notes
#[serde(rename_all = "lowercase")]maps the variant to"evaluation".matchonModelFlavorexists in the tree, so this is purely additive.Validation
cargo test -p braintrust-llm-routerpasses.braintrustrepo (with the proxy submodule bumped to include #1267): the previously-panicking gateway tests now pass —cargo test -p gateway --lib proxy::router_builder::tests(36 passed) andserver::tests::supports_modern_and_legacy_prefixes— andcargo fmt -- --checkis clean.🤖 Generated with Claude Code