Keep Pi tool spans current during execution - #2499
Open
Aaron (btaaron) wants to merge 2 commits into
Open
Aaron (btaaron) wants to merge 2 commits into
Aaron (btaaron) wants to merge 2 commits into
Conversation
Aaron (btaaron)
marked this pull request as ready for review
September 17, 2026 19:13
Aaron (btaaron)
enabled auto-merge (squash)
September 17, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit flagged that Pi creates an automatic tool span, but
currentSpan()inside the tool still returns the outer span, meaning nested spans get the wrong parent. This fix binds the existing tool span while its executor runs, preserving caller context and executor's return and error behavior. Fixes SDK-389Tested
80af362c. All 53 context observations use correct tool span after fix. Covers overlapping sessions with reused call IDs, session reuse, nested traces, sync throw, async rejection, caller restoration