Skip to content

Fix confusing warning per issue #295 #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dboreham merged 1 commit into from
Aug 24, 2026
Merged

Fix confusing warning per issue #295 #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/stack/build/build_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,11 +570,14 @@ def build_containers(parent_stack, # noqa: C901
if wrapper_used:
if not identity.wrapper_pin:
deviating_inputs.append(f"wrapper:{wrapper_used['hash']}{'-dirty' if wrapper_used['dirty'] else ''}")
elif wrapper_used["dirty"] or (
wrapper_used["hash"] and wrapper_used["hash"] != identity.wrapper_pin.get("hash")):
elif wrapper_used["hash"] and wrapper_used["hash"] != identity.wrapper_pin.get("hash"):
log_warn(f"WARN: wrapper {wrapper_used['name']} at {wrapper_used['hash']} "
f"does not match locked hash {identity.wrapper_pin.get('hash')}.", bold=True)
deviating_inputs.append(f"wrapper:{wrapper_used['hash']}{'-dirty' if wrapper_used['dirty'] else ''}")
elif wrapper_used["dirty"]:
log_warn(f"WARN: wrapper {wrapper_used['name']} checkout has local modifications, "
f"so it deviates from locked hash {identity.wrapper_pin.get('hash')}.", bold=True)
deviating_inputs.append(f"wrapper:{wrapper_used['hash']}-dirty")

# The actual inputs are known now, so settle the image identity.
if identity.recipe_fs_path and Path(identity.recipe_fs_path).exists():
Expand Down