Fix node list all flag - #128
Merged
Johan-Liebert1 merged 1 commit intoAug 24, 2026
Merged
Conversation
The --all flag was accepted but never used — all nodes (running and stopped) were always shown. Wire it up so that non-running nodes are hidden by default and shown when --all is passed. Fixes: bootc-dev#126 Assisted-by: AI Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
HarshwardhanPatil07
force-pushed
the
fix-node-list-all-flag
branch
from
August 24, 2026 05:39
1cffbed to
63074b2
Compare
Collaborator
Author
Johan-Liebert1
approved these changes
Aug 24, 2026
|
|
||
| state = strings.TrimSpace(state) | ||
|
|
||
| if !showAll && state != "running" { |
Collaborator
There was a problem hiding this comment.
We should really use constants and not have strings floating around in code. Not a blocker though
Collaborator
Author
There was a problem hiding this comment.
it needs overall cleanup i guess? should this be done as followup pr?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #126
What I did: