Release 6.1.8 - #3806
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
APP_SECRET validation currently relies on empty()/truthiness and double getenv() calls, which can mis-handle valid string values and is easily fixable in the touched code path.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Release 6.1.8 updates Bolt鈥檚 core/templates to tighten a couple of security-related behaviors and documents the release in the changelog.
Changes:
- Hardened
secret()generation to requireAPP_SECRET(instead of silently hashing with an empty/missing secret). - Escaped
searchTermwhen interpolating it into a translated, HTML-safe search title. - Added the 6.1.8 entry to
CHANGELOG.md.
File summaries
| File | Description |
|---|---|
| src/Twig/CommonExtension.php | Makes generateSecret() fail fast when APP_SECRET is missing. |
| public/theme/skeleton/search.twig | Escapes user-controlled search input when included in translated output. |
| CHANGELOG.md | Documents the 6.1.8 release date and highlights security/translation updates. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.