Conversation
github-actions
Bot
added
Waiting On Review
Test262 conformance changes
Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5524 +/- ##
===========================================
+ Coverage 47.24% 63.10% +15.86%
===========================================
Files 476 536 +60
Lines 46892 60314 +13422
===========================================
+ Hits 22154 38064 +15910
+ Misses 24738 22250 -2488 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jedel1043
reviewed
Sep 18, 2026
| let mut signal = signal; | ||
|
|
||
| let request: Request<Vec<u8>> = match resource { | ||
| let (request, input_has_body): (Request<Vec<u8>>, bool) = match resource { |
Member
There was a problem hiding this comment.
can we have something like Request<Option<Vec<u8>>>? If the semantics of an empty body and no body are different, we should try to represent that in the request itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, bodyless
fetch(url, { method: "GET" })is incorrectly rejected, because an internal empty byte vector is treated as a present body. The patch tracks body presence separately.