-
Notifications
You must be signed in to change notification settings - Fork 1
feat: share Claude and Codex skills in the container feature #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9580267
feat: share Claude and Codex skills in the container feature
blooop 1fb7138
fix: an undocumented writable bind of any host home directory passed …
blooop 9cdeacb
fix: the README accessor silently dropped every path outside ~/.claude
blooop 5291f90
fix: the namespace scenario could mkdir and bind-mount over the real …
blooop 7cf77d0
fix: "readonly" in mount was True for readonly=false and False for ro
blooop 1f9651d
fix: the documented remedy for a refused create left the create refused
blooop a9edcb0
fix: resolve()'s argument changed meaning and kept its name
blooop a992042
fix: two comments the diff falsified
blooop 32d8158
fix: a home-relative path from the README could escape the scratch home
blooop efc7afe
fix: a second writable bind of a protected source passed every guard
blooop 541efd7
fix: the guard named five copies of the mount list and diffed four
blooop caf2c1b
fix: TROUBLESHOOTING.md promised read-only protection for two writabl…
blooop 5e98fbf
fix: resolve()'s docstring described a defect it can no longer have
blooop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (broader_impact): The documentation requires dotfiles installers to detect and skip the host-mounted
~/.agents/skillsroot, but the diff adds no installer or mount-ownership handling for that path. A dotfiles refresh therefore still treats the read-only host bind as container-owned state and attempts to reconcile it, causing failures on the read-only mount or violating the promise to preserve existing skills and links.Triggers: When a workspace using this feature runs its dotfiles installer or refreshes dotfiles.
Suggested fix: Update the dotfiles provisioning path to detect the
~/.agents/skillsmount in/proc/self/mountinfoand exclude that root, including its descendants, from reconciliation.