Cut 0.34.0 - #587
Merged
Merged
Conversation
The [Unreleased] section as it stood becomes the release, and it is two fixes,
both about what a container comes up holding.
A forwarded Claude login no longer loses to an empty credentials file. The
devcontainer feature seeded `{}` into `.credentials.json`, Claude Code reads
that file before the environment, and an empty one is not a placeholder but a
logged-out session: `dl --claude-profile bear <ws>` resolved the profile,
forwarded the token and got asked to log in anyway. Removing the stub fixed a
second thing nobody was looking for -- `.claude.json` went with it, and the
provisioner's `hasCompletedOnboarding` seed exits early when that file exists,
so the stub had been suppressing devlaunch's own onboarding of every container
this feature built.
The ssh agent socket is bound from `$SSH_AUTH_SOCK` instead of a guess at
`~/.ssh/agent.sock`. On a host whose agent is gpg-agent or a stock `ssh-agent`,
that path does not exist and `devpod up` refused the create before the container
existed, which reads as a broken tool rather than as a manifest naming a path
the host never had.
**0.34.0 and not 0.33.1.** Neither entry adds a flag or moves the CLI surface,
so the patch reading is available -- but what a launch produces changes in three
ways: a profile token that was ignored is now honoured, the onboarding seed
lands where it never had, and the agent socket comes from somewhere else. That
is the same test 0.33.0 applied to itself. 0.30.0 stays skipped for c1ef6f5's
reason.
Mechanical otherwise. The README's conda badge and its `dl --version` transcript
move with the version, which test_readme_cli_doc holds, and the lockfile follows
the workspace version for dl, aid, devlaunch-core, devlaunch-runner and
devlaunch-test-support.
Cut on a release branch so the version bump is a reviewable diff and the publish
fires on the merge.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis release cut promotes Unreleased to 0.34.0 and synchronizes the changelog, README, workspace metadata, and lockfile; the documented functional fixes are the removal of container credential/onboarding stubs and binding the SSH agent from $SSH_AUTH_SOCK, though those implementation changes are not present in the supplied diff. Sequence diagram for forwarded Claude authenticationsequenceDiagram
participant Profile as ClaudeProfile
participant Launcher as Devlaunch
participant Container as Container
participant Claude as ClaudeCode
Profile->>Launcher: resolve profile
Launcher->>Container: forward Claude token
Container->>Claude: start without .credentials.json
Claude->>Container: read environment token
Container-->>Claude: authenticated session
Sequence diagram for SSH agent socket bindingsequenceDiagram
participant Host as Host
participant Launcher as Devpod
participant Container as Container
participant Agent as SSHAgent
Host->>Launcher: provide SSH_AUTH_SOCK
Launcher->>Container: bind SSH_AUTH_SOCK socket
Container->>Agent: connect through bound socket
Agent-->>Container: authorize SSH operation
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
## [Unreleased]to## [0.34.0]. Two fixes, both about what a container comes up holding.A forwarded Claude login no longer loses to an empty credentials file. The devcontainer feature seeded
{}into.credentials.json, Claude Code reads that file before the environment, and an empty one is not a placeholder but a logged-out session:dl --claude-profile bear <ws>resolved the profile, forwarded the token and got asked to log in anyway. Removing the stub fixed a second thing nobody was looking for..claude.jsonwent with it, and the provisioner'shasCompletedOnboardingseed exits early when that file exists, so the stub had been suppressing devlaunch's own onboarding of every container this feature built.The ssh agent socket is bound from
$SSH_AUTH_SOCKinstead of a guess at~/.ssh/agent.sock. On a host whose agent is gpg-agent or a stockssh-agent, that path does not exist anddevpod uprefused the create before the container existed.0.34.0 and not 0.33.1
Neither entry adds a flag or moves the CLI surface, so the patch reading is available. But what a launch produces changes in three ways: a profile token that was ignored is now honoured, the onboarding seed lands where it never had, and the agent socket comes from somewhere else. That is the same test 0.33.0 applied to itself. 0.30.0 stays skipped for c1ef6f5's reason.
Mechanical otherwise
The README's conda badge and its
dl --versiontranscript move with the version, whichtest_readme_cli_docholds, and the lockfile follows the workspace version fordl,aid,devlaunch-core,devlaunch-runneranddevlaunch-test-support. Four files, the same four the 0.33.0 cut touched.Verified locally:
dl --versionprintsdl 0.34.0, 728 tests pass, prek clean.🤖 Generated with Claude Code
Summary by Sourcery
Release version 0.34.0 with fixes for Claude authentication forwarding and SSH agent setup.
Bug Fixes:
Build:
Documentation: