Skip to content

ci: do not ignore NIXPKGS_CHANNEL in local ci runs - #351

Open
ryanofsky wants to merge 2 commits into
bitcoin-core:masterfrom
ryanofsky:pr/ci-channel
Open

ci: do not ignore NIXPKGS_CHANNEL in local ci runs#351
ryanofsky wants to merge 2 commits into
bitcoin-core:masterfrom
ryanofsky:pr/ci-channel

Conversation

@ryanofsky

@ryanofsky ryanofsky commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Currently, the olddeps ci job specifies nixos-25.05 channel, but this is ignored in local ci runs, because the channel is set in .github/workflows/ci.yml not ci/scripts/run.sh.

Fix this and also rename CI environment variables to consistently use CI_ prefix

@ryanofsky
ci: do not ignore NIXPKGS_CHANNEL in local ci runs
fe1b833 
Currently, olddeps ci job specifies nixos-25.05 channel, but this is
ignored in local ci runs, because the NIXPKGS_CHANNEL is passed as the
cachiex nix path instead of being passed directly to nix develop.

Fix this and also rename the NIXPKGS_CHANNEL environment variable to
CI_NIXPKGS_CHANNEL because CI configuration variables are supposed to
have the CI_ prefix. The NIXPKGS_CHANNEL looks misleadingly like an
upstream configuration variable when it's just a local setting.
@ryanofsky
ci: rename CI-internal variables to use CI_ prefix
7c73cce
@DrahtBot

DrahtBot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers
ACK maflcko

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #175 (Set cmake_minimum_required(VERSION 3.22) by maflcko)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko

maflcko commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

looks like CI failed?

@ryanofsky

ryanofsky commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

Updated 723ba1c -> 7c73cce (pr/ci-channel.1 -> pr/ci-channel.2, compare) to fix caching failure in gnu32 job https://github.com/bitcoin-core/libmultiprocess/actions/runs/32414275828/job/96571710982?pr=351

@DrahtBot DrahtBot mentioned this pull request Aug 21, 2026
Open
@maflcko

maflcko commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

review ACK 7c73cce 🌘

Show signature

Signature:

untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 7c73cceda9b4149b706dd667f70cbea381d6364a 🌘
Xug1r/picv5dfCotLW8QPGTfg7E0epFbqHrtmW8H34WlTXEBakoayo2ytgKdbmrkFcpsrAhZWNZ2A7rN2MBSAw==

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanofsky @DrahtBot @maflcko