Skip to content

fix(questions): correct inverted minus scoring for zh-cn and vi in the published 1.6.x source - #32

Open
csliubo wants to merge 2 commits into
bigfive-org:mainfrom
csliubo:fix-zh-cn-choices-scoring
Open

fix(questions): correct inverted minus scoring for zh-cn and vi in the published 1.6.x source#32
csliubo wants to merge 2 commits into
bigfive-org:mainfrom
csliubo:fix-zh-cn-choices-scoring

Conversation

@csliubo

@csliubo csliubo commented Aug 27, 2026

Copy link
Copy Markdown

Fixes the zh-cn and vi scoring bug documented in #31retargeted to the actually-published source after tracing the release pipeline.

What & where

The live @bigfive-org/questions@1.6.4 is built from old-packages/questions/ (auto-published to npm with --tag beta by questions-publish.yaml on push), not from packages/questions/. This PR therefore patches:

  1. old-packages/questions/data/zh-cn/choices.js — the minus array had its labels in reversed order while keeping scores 5..1, so on all 55 reverse-keyed items 非常不准确 (Very Inaccurate) recorded 1 instead of 5. Roughly half of every zh-cn result is scored backwards; the all-minus facets (A2 Morality, A4 Cooperation, A5 Modesty, C6 Cautiousness) come out fully inverted. Restored the invariant used by en and the other 39 correct locales: minus lists the same labels in the same display order as plus, scores 5..1. Also replaced the score-2 label 不太不准确 (an ungrammatical double negative) with 比较不准确 to match Moderately Inaccurate.
  2. old-packages/questions/data/vi/choices.js — identical defect, same structural fix.
  3. old-packages/questions/package.json1.6.41.6.5. Two reasons: npm won't accept a same-version republish, and the workflow's paths filter old-packages/questions/* doesn't match nested files (single * doesn't cross /), so a data-only change would not trigger the publish — the package.json change does. If you'd rather control versioning yourself, say the word and I'll drop this hunk.

Verified end-to-end against a local build of the site

Linked web/ to the patched package via a pnpm override and fetched /zh-cn/test from a local dev server. Served payload after the fix:

plus:  非常不准确→1 … 非常准确→5   (unchanged, correct)
minus: 非常不准确→5 … 非常准确→1   (fixed; live site currently serves 非常准确→5 first)

Follow-up for maintainers

  • web/package.json pins @bigfive-org/questions: 1.6.4 — it needs a bump to 1.6.5 after CI publishes the new version. Left out of this PR deliberately: bundling it would race the Vercel build against the npm publish in the same merge.
  • Historical zh-cn / vi results stored since the 1.6.x rollout cannot be distinguished from clean ones without raw answers; a note to affected users may be worth considering.
  • Full forensics (npm diff, live payload capture, 41-locale structural scan): [Bug] zh-cn and vi: all 55 reverse-keyed items are scored inverted on the live site (@bigfive-org/questions 1.6.4) #31.

🤖 Generated with Claude Code — analysis and patch produced with AI assistance, disclosed in the commit trailers.

https://claude.ai/code/session_01C5EiE3nDRxWdHLt3r3xgpx

The published @bigfive-org/questions 1.6.4 (used by the live site) ships a
zh-cn minus array with labels in reversed order while keeping scores 5..1,
so every reverse-keyed item is scored inverted: answering 非常不准确 (Very
Inaccurate) records 1 instead of 5. 55 of 120 IPIP-NEO-120 items are
reverse-keyed, so roughly half of every zh-cn result is scored backwards.

This updates the repo copy to the modern label set with the correct
mapping (minus lists the same label order as plus, scores 5..1), and
replaces the score-2 label 不太不准确 (a double negative) with 比较不准确
to match 'Moderately Inaccurate'.

See bigfive-org#31 for full forensics (also affects vi, which is not in this repo).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C5EiE3nDRxWdHLt3r3xgpx
@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@headlessQ is attempting to deploy a commit to the Big Five Team on Vercel.

A member of the Team first needs to authorize it.

… source (zh-cn, vi)

The live source of @bigfive-org/questions 1.6.4 is old-packages/questions
(auto-published to npm with --tag beta by questions-publish.yaml), not
packages/questions. Retarget the fix there:

- zh-cn & vi: restore the minus invariant (same label order as plus,
  scores 5..1) so reverse-keyed items score correctly again
- zh-cn: replace the double-negative score-2 label 不太不准确 with 比较不准确
- bump 1.6.4 -> 1.6.5; the package.json change also matches the workflow's
  'old-packages/questions/*' paths filter (single * does not cross '/', so
  a data-only change would not have triggered the publish)
- revert the earlier packages/questions edit to keep this PR surgical

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C5EiE3nDRxWdHLt3r3xgpx
@csliubo

csliubo commented Aug 27, 2026

Copy link
Copy Markdown
Author

Closing this for now while I double-check the fix against the actual release pipeline — will reopen (or resubmit) once verified. The full bug forensics remain in #31.

@csliubo csliubo closed this Aug 27, 2026
@csliubo csliubo reopened this Aug 27, 2026
@csliubo csliubo changed the title fix(questions): correct inverted minus scoring for zh-cn choices fix(questions): correct inverted minus scoring for zh-cn and vi in the published 1.6.x source Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants