fix(questions): correct inverted minus scoring for zh-cn and vi in the published 1.6.x source - #32
Open
csliubo wants to merge 2 commits into
Open
fix(questions): correct inverted minus scoring for zh-cn and vi in the published 1.6.x source#32csliubo wants to merge 2 commits into
csliubo wants to merge 2 commits into
Conversation
The published @bigfive-org/questions 1.6.4 (used by the live site) ships a zh-cn minus array with labels in reversed order while keeping scores 5..1, so every reverse-keyed item is scored inverted: answering 非常不准确 (Very Inaccurate) records 1 instead of 5. 55 of 120 IPIP-NEO-120 items are reverse-keyed, so roughly half of every zh-cn result is scored backwards. This updates the repo copy to the modern label set with the correct mapping (minus lists the same label order as plus, scores 5..1), and replaces the score-2 label 不太不准确 (a double negative) with 比较不准确 to match 'Moderately Inaccurate'. See bigfive-org#31 for full forensics (also affects vi, which is not in this repo). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5EiE3nDRxWdHLt3r3xgpx
|
@headlessQ is attempting to deploy a commit to the Big Five Team on Vercel. A member of the Team first needs to authorize it. |
… source (zh-cn, vi) The live source of @bigfive-org/questions 1.6.4 is old-packages/questions (auto-published to npm with --tag beta by questions-publish.yaml), not packages/questions. Retarget the fix there: - zh-cn & vi: restore the minus invariant (same label order as plus, scores 5..1) so reverse-keyed items score correctly again - zh-cn: replace the double-negative score-2 label 不太不准确 with 比较不准确 - bump 1.6.4 -> 1.6.5; the package.json change also matches the workflow's 'old-packages/questions/*' paths filter (single * does not cross '/', so a data-only change would not have triggered the publish) - revert the earlier packages/questions edit to keep this PR surgical Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5EiE3nDRxWdHLt3r3xgpx
Author
|
Closing this for now while I double-check the fix against the actual release pipeline — will reopen (or resubmit) once verified. The full bug forensics remain in #31. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the zh-cn and vi scoring bug documented in #31 — retargeted to the actually-published source after tracing the release pipeline.
What & where
The live
@bigfive-org/questions@1.6.4is built fromold-packages/questions/(auto-published to npm with--tag betabyquestions-publish.yamlon push), not frompackages/questions/. This PR therefore patches:old-packages/questions/data/zh-cn/choices.js— theminusarray had its labels in reversed order while keeping scores5..1, so on all 55 reverse-keyed items 非常不准确 (Very Inaccurate) recorded 1 instead of 5. Roughly half of every zh-cn result is scored backwards; the all-minus facets (A2 Morality, A4 Cooperation, A5 Modesty, C6 Cautiousness) come out fully inverted. Restored the invariant used byenand the other 39 correct locales: minus lists the same labels in the same display order as plus, scores5..1. Also replaced the score-2 label 不太不准确 (an ungrammatical double negative) with 比较不准确 to match Moderately Inaccurate.old-packages/questions/data/vi/choices.js— identical defect, same structural fix.old-packages/questions/package.json—1.6.4→1.6.5. Two reasons: npm won't accept a same-version republish, and the workflow's paths filterold-packages/questions/*doesn't match nested files (single*doesn't cross/), so a data-only change would not trigger the publish — the package.json change does. If you'd rather control versioning yourself, say the word and I'll drop this hunk.Verified end-to-end against a local build of the site
Linked
web/to the patched package via a pnpm override and fetched/zh-cn/testfrom a local dev server. Served payload after the fix:Follow-up for maintainers
web/package.jsonpins@bigfive-org/questions: 1.6.4— it needs a bump to1.6.5after CI publishes the new version. Left out of this PR deliberately: bundling it would race the Vercel build against the npm publish in the same merge.🤖 Generated with Claude Code — analysis and patch produced with AI assistance, disclosed in the commit trailers.
https://claude.ai/code/session_01C5EiE3nDRxWdHLt3r3xgpx