refactor: W1: settle group, environment, and rank terminology - #524
Merged
Conversation
This was referenced Aug 30, 2026
dannash100
marked this pull request as ready for review
August 31, 2026 03:33
passcod
approved these changes
Aug 31, 2026
passcod
added a commit
that referenced
this pull request
Sep 1, 2026
…tion Split the core model: machines, application servers, and identities (V2) W1 (PR #524) retires "deployment" for group, environment, and the Canopy instance, and adds an AGENTS.md grep rule to keep it retired. Sweeps the ~24 uses this branch introduced, leaving main's ~322 to W1 so the two open PRs do not both rewrite the same prose. billing.deployment keeps its spelling, being read outside Canopy. W1's GRP defines an environment as a group's servers at one rank, which stops meaning one thing once servers split: rank lives only on applications while group_id lives on both grains. So an environment is a set of applications, a machine belongs to a group without belonging to any of its environments, and a machine's stage is derived as the highest rank among the applications on it, which is what APP already says about billing. Settled in FLT because this branch is what introduces the distinction; the cross-reference to GRP goes in when W1 lands. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
passcod
added a commit
that referenced
this pull request
Sep 2, 2026
…tion Split the core model: machines, application servers, and identities (V2) W1 (PR #524) retires "deployment" for group, environment, and the Canopy instance, and adds an AGENTS.md grep rule to keep it retired. Sweeps the ~24 uses this branch introduced, leaving main's ~322 to W1 so the two open PRs do not both rewrite the same prose. billing.deployment keeps its spelling, being read outside Canopy. W1's GRP defines an environment as a group's servers at one rank, which stops meaning one thing once servers split: rank lives only on applications while group_id lives on both grains. So an environment is a set of applications, a machine belongs to a group without belonging to any of its environments, and a machine's stage is derived as the highest rank among the applications on it, which is what APP already says about billing. Settled in FLT because this branch is what introduces the distinction; the cross-reference to GRP goes in when W1 lands. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
# Conflicts: # .workhorse/specs/jobs/backup.md # .workhorse/specs/monitoring/maintenance.md # .workhorse/specs/private-server/mcp.md # .workhorse/specs/private-server/upgrade-plans.md # .workhorse/specs/public-server/certificates.md # .workhorse/specs/public-server/restore-replicas.md # .workhorse/specs/servers/domains.md # .workhorse/specs/servers/products.md # crates/commons-servers/src/backup_jobs.rs # crates/commons-types/src/server/kind.rs # crates/commons-types/src/server/product.rs # crates/database/src/applications.rs # crates/private-server/src/fns/applications.rs # crates/private-server/src/fns/certificates.rs # crates/private-server/src/fns/statuses.rs # crates/private-server/tests/it/server_products.rs # crates/public-server/src/restore.rs # private-web/e2e/maintenance.spec.ts # private-web/openapi.json # private-web/src/api-types.ts # private-web/src/routes/ServerEdit.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canopy called three things a deployment: a group, one rank inside a group, and Canopy's own installation.
servers/groups.md(GRP): the state a group holds, how its headline rank derives, what an environment names. Cardinality stays FLT's.AGENTS.mdcarries the grep check so it stays retired.billing.deploymentis untouched: AWS cost allocation and every machine's effective tags read it.Merged over the machines/applications split, so the sweep covers what landed since.