Ignore loaded tags that only contain the desired tag - #492
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
get_maximum_tag_increaser/2 stripped the desired tag from every loaded tag containing it and parsed the remainder as an integer, which raised for tags like "foo-baseline". Those are no increments of the desired tag, so they are ignored and the next free increment is used instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_maximum_tag_increaser/2strips the desired tag from every loaded tag that contains it and parses the rest withString.to_integer/1. That remainder is only a number for tags of the formfooorfoo-N, so any other loaded tag containing the desired tag -foobar,foo-baseline- raised anArgumentErrorand nothing was saved.Those tags are no increments of the desired tag, so they are ignored now and the next free increment is used, which is
foo-1when none of the loaded tags are an increment offoo.Verified with
mix test test/benchee/formatters/tagged_save_test.exs- the new test raises:erlang.binary_to_integer("baseline")on the unpatched code - plusmix format --check-formatted,mix credoandmix dialyzer. The full suite only fails the memory sample size assertion inrunner_test.exs:500, which also fails on an unmodified checkout in this environment.Fixes #491