Check all remaining unchecked error returns - #502
Merged
Conversation
KillerX
force-pushed
the
fix/20-errcheck
branch
from
August 21, 2026 10:59
25efcec to
7680129
Compare
Per-site treatment instead of blanket discards: - Best-effort telegram notifications (activities/audio.go, ingest notify helpers, wfutils telegram message update) log the failure and continue. - Failures that matter now propagate: vsapi placeholder template rendering, workflow.Sleep delays, playlist file close before ffmpeg reads it. - vb_export dubbing move/copy errors are logged in the transcode callback, and a failed move skips the copy. - Deferred Close/Remove on read-only or scratch resources use explicit discards. - Tests assert errors via require/assert/s.NoError, use t.Setenv instead of os.Setenv, and testutils generators panic on MkdirAll failure consistent with their ffmpeg handling. golangci-lint errcheck now reports 0 issues (with max-same-issues uncapped). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
KillerX
force-pushed
the
fix/20-errcheck
branch
from
August 21, 2026 11:09
7680129 to
8f56416
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all 85 errcheck findings (the default linter caps hid duplicates beyond the reported 42): best-effort notification sends are logged, consequential errors propagate, deferred closes are explicit, tests use require/assert and t.Setenv. errcheck now reports 0 issues. Also records a newly found bug (AnalyzeEBUR128Activity ignores its probe error) in potential_improvements.md.
Part of the stacked bugfix series fix/00 → fix/20; based on
fix/19-panic-indexing.🤖 Generated with Claude Code