Skip to content

⚡ Optimize convert_gitmodules_to_entries by removing redundant HashMap allocations #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bashandbone merged 1 commit into from
Aug 11, 2026
Merged

⚡ Optimize convert_gitmodules_to_entries by removing redundant HashMap allocations #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/git_ops/gix_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,8 @@ impl GixOperations {
|| section.header().name().to_string(),
|subsection| subsection.to_string(),
);
let body_entries = section.body().into_iter().collect::<HashMap<_, _>>();
for (key, value) in body_entries {
section_entries.insert(key.clone().clone(), value.to_string().clone());
for (key, value) in section.body() {
section_entries.insert(key.clone(), value.to_string());
}
sections_map.insert(name, section_entries);
}
Expand Down Expand Up @@ -239,8 +238,7 @@ impl GitOperations for GixOperations {
for section in config_snapshot.sections() {
if section.meta().source == source_filter {
let section_name = section.header().name();
let body_iter = section.body().into_iter();
for (key, value) in body_iter {
for (key, value) in section.body() {
entries.insert(format!("{section_name}.{key}"), value.to_string());
}
}
Expand Down
Loading