Skip to content

fix: correct broken EIP-8130 links in beryl overview - #1782

Open
teyrebaz33 wants to merge 1 commit into
base:masterfrom
teyrebaz33:fix/beryl-eip-8130-broken-links
Open

fix: correct broken EIP-8130 links in beryl overview#1782
teyrebaz33 wants to merge 1 commit into
base:masterfrom
teyrebaz33:fix/beryl-eip-8130-broken-links

Conversation

@teyrebaz33

Copy link
Copy Markdown

Closes #1781

Problem

docs/base-chain/specs/upgrades/beryl/overview.mdx had two links pointing to /base-chain/specs/upgrades/beryl/eip-8130, which doesn't exist. The EIP-8130 page actually lives under cobalt.

Fix

Updated both links to point to /base-chain/specs/upgrades/cobalt/eip-8130, the correct existing path.

Verification

Ran node scripts/lint-mdx.js docs/base-chain/specs/upgrades/beryl/overview.mdx before and after — the "Possibly broken internal link" warning is resolved, 0 errors/warnings after the fix.

The Native Account Abstraction (EIP-8130) page lives under the cobalt
upgrade path (docs/base-chain/specs/upgrades/cobalt/eip-8130.mdx), not
under beryl. Two links in beryl/overview.mdx pointed to a non-existent
/base-chain/specs/upgrades/beryl/eip-8130 path, resulting in a 404.
@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken links to EIP-8130 page in beryl/overview.mdx (should point to cobalt)

2 participants