Skip to content

chore(pr-sync) - Updated action to run using Node v24 - #186

Closed
fearphage wants to merge 2 commits into
backstage:mainfrom
fearphage:pr-sync/node-v24
Closed

fearphage wants to merge 2 commits into
backstage:mainfrom
fearphage:pr-sync/node-v24

Conversation

@fearphage

Copy link
Copy Markdown
Contributor
  • Added Node v24 to the CI testing matrix
  • Updated some core action (actions/*) versions
  • Switched action to use node24
    This will get rid of Node v20 deprecation warnings.
  • Added some security-related things to the CI workflow (permissions, disabled persist-credentials)

Note

There's an unrelated test that is failing locally that I will fix in a separate PR.

Signed-off-by: Phred <fearphage@gmail.com>

@freben freben left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look sound in isolation, including the Node 24 runtime change and the CI permission and credential-hardening updates. Before merging, can we consolidate this with #166? Both PRs change pr-sync/action.yml to node24, while #166 updates all of the other remaining node20 custom actions and this PR contains the newer CI improvements.

My preferred outcome would be to fold this PRs CI and security changes into #166, or expand this PR to cover the remaining actions and close #166, rather than merge overlapping migrations independently.

The new Node 20/24 matrix has also not actually run on GitHub yet; only the sync check is present and the fork workflow awaits approval. Please run CI after the PRs are consolidated. I did not find a code-level correctness blocker beyond the overlap and verification gap.

@fearphage
fearphage requested a review from freben September 4, 2026 13:55
@freben

freben commented Sep 7, 2026

Copy link
Copy Markdown
Member

Hey! Thanks again for this, sorry I believe #188 happened to supersede this - closing. Let know if that was wrong (maybe on discord, easy to miss here)

@freben freben closed this Sep 7, 2026
@fearphage

Copy link
Copy Markdown
Contributor Author

@freben 2 benefits to this PR:

  1. The versions can update independent of each other. As it stands, when it's time for Node 26, this same line will have to be touched. With more "standard" or default, YAML ussage, 1 line will be removed (v22) and 1 line will be added (v26).
  2. Also setting the CI variable to the default value that it already has is pointless/wasted effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants