feat: add should_complete to CompletionConfig - #605
Open
ayushiahjolia wants to merge 1 commit into
Open
Conversation
ayushiahjolia
had a problem deploying
to
ai-pr-review
July 31, 2026 05:03 — with
GitHub Actions
Error
ayushiahjolia
had a problem deploying
to
ai-pr-review
July 31, 2026 05:20 — with
GitHub Actions
Error
ayushiahjolia
force-pushed
the
feat/custom-completion-predicate
branch
from
July 31, 2026 05:22
862e017 to
c72785b
Compare
ayushiahjolia
temporarily deployed
to
ai-pr-review
July 31, 2026 05:22 — with
GitHub Actions
Inactive
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
July 31, 2026 05:36 — with
GitHub Actions
Inactive
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
July 31, 2026 05:36 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
feat/custom-completion-predicate
branch
from
July 31, 2026 19:22
c72785b to
306c81c
Compare
ayushiahjolia
temporarily deployed
to
ai-pr-review
July 31, 2026 19:22 — with
GitHub Actions
Inactive
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
July 31, 2026 19:39 — with
GitHub Actions
Failure
ayushiahjolia
had a problem deploying
to
ai-pr-review-runtime
July 31, 2026 19:39 — with
GitHub Actions
Failure
ayushiahjolia
force-pushed
the
feat/custom-completion-predicate
branch
from
July 31, 2026 19:44
306c81c to
5483a62
Compare
ayushiahjolia
temporarily deployed
to
ai-pr-review
July 31, 2026 19:49 — with
GitHub Actions
Inactive
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
July 31, 2026 20:13 — with
GitHub Actions
Inactive
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
July 31, 2026 20:13 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
feat/custom-completion-predicate
branch
from
July 31, 2026 21:17
5483a62 to
fffee6d
Compare
ayushiahjolia
temporarily deployed
to
ai-pr-review
July 31, 2026 21:17 — with
GitHub Actions
Inactive
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
July 31, 2026 21:18 — with
GitHub Actions
Inactive
ayushiahjolia
temporarily deployed
to
ai-pr-review-runtime
July 31, 2026 21:18 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ayushiahjolia
force-pushed
the
feat/custom-completion-predicate
branch
from
July 31, 2026 21:55
fffee6d to
7ad4242
Compare
ayushiahjolia
had a problem deploying
to
ai-pr-review
July 31, 2026 21:55 — with
GitHub Actions
Error
ayushiahjolia
force-pushed
the
feat/custom-completion-predicate
branch
from
July 31, 2026 21:56
7ad4242 to
302330d
Compare
ayushiahjolia
temporarily deployed
to
ai-pr-review
July 31, 2026 21:56 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Codex AI reviewFound two correctness issues in custom predicate scheduling. Resume ordering and Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #519
Description of changes:
Adds a
should_completepredicate to CompletionConfig for map and parallel operations, giving full control over when a batch completes early.The predicate receives a CompletionStatus snapshot (counts + per-item statuses) and returns a CompletionDecision - either continue_batch() or complete_batch(outcome). The outcome determines whether
CUSTOM_COMPLETION_SUCCEEDEDorCUSTOM_COMPLETION_FAILEDis reported.Key design decisions -
Testing -
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.