feat(cdk-assets): redact secret-bearing flag values from logged docker commands - #1904
Draft
iankhou wants to merge 2 commits into
Draft
feat(cdk-assets): redact secret-bearing flag values from logged docker commands#1904iankhou wants to merge 2 commits into
iankhou wants to merge 2 commits into
Conversation
… commands `shell()` logs the command line on open/close and embeds it in the failure message. For `docker build`, `--build-arg VALUE` (passed literally) and `--secret` specs could carry secrets straight into logs. Add an opt-in `redactFlags` to `shell()` that masks the value after each listed flag wherever the command line is surfaced to a human — the open/close events AND the failure message (which `run()` renders from the raw argv) — while the real value is still passed to the process. docker `build` opts in with `['--build-arg', '--secret']`. Also documents the one audited "quote-for-execution" boundary (`quoteShellPart` in toolkit-lib) in the subprocess module header, so the "nothing both escapes and executes" model is stated completely.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
iankhou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1763 / #1849 (the subprocess consolidation).
Description
This is not a regression. Previous to the subprocess module, we didn't have a mechanism to redact params like --build-arg and --secret either.
shell()logs the command line on theopen/closeevents and embeds it in the failure message. Fordocker build,--build-arg VALUE(passed literally) and--secretspecs can log secrets.Adds opt-in option
redactFlagstoshell()that masks the value after each listed flag while the real value is still passed to the process.docker buildopts in with['--build-arg', '--secret'].Also documents the single audited "quote-for-execution" boundary (
quoteShellPartin toolkit-lib) in the subprocess module header.Testing
shell.test.ts: 5/5 pass, including two new testsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.