feat(toolkit-lib): support CloudFormation rollback triggers - #1881
feat(toolkit-lib): support CloudFormation rollback triggers#1881mattmb-aws wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
- Coverage 91.10% 91.08% -0.02%
==========================================
Files 80 80
Lines 12205 12233 +28
Branches 1742 1744 +2
==========================================
+ Hits 11119 11143 +24
- Misses 1050 1054 +4
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Expose CloudFormation rollback triggers (rollback alarms + monitoring time) so a stack create/update is automatically rolled back when a CloudWatch alarm breaches. - toolkit-lib: new public `rollbackConfiguration` deploy option (RollbackConfiguration/RollbackTrigger/RollbackTriggerType). It is validated (<=5 triggers, valid alarm ARNs, 0-180 min) and threaded through to the Create/Update/CreateChangeSet calls, with change detection so an unchanged config does not force a deployment. - cli: new `cdk deploy --rollback-trigger-alarm-arns` and `--monitoring-time-minutes` flags. CLI ARNs default to metric alarms; composite alarms are reachable via the programmatic API. Follows the same undefined/[]/[...] management semantics as notificationArns. Fixes aws/aws-cdk#5170 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
085e00f to
bd51232
Compare
Design verdict: PASS
🔴 Must-fix (1)
|
Expose CloudFormation rollback triggers (rollback alarms + monitoring time) so a stack create/update is automatically rolled back when a CloudWatch alarm breaches.
rollbackConfigurationdeploy option (RollbackConfiguration/RollbackTrigger/RollbackTriggerType). It is validated (<=5 triggers, valid alarm ARNs, 0-180 min) and threaded through to the Create/Update/CreateChangeSet calls, with change detection so an unchanged config does not force a deployment.cdk deploy --rollback-trigger-alarm-arnsand--monitoring-time-minutesflags. CLI ARNs default to metric alarms; composite alarms are reachable via the programmatic API.Follows the same undefined/[]/[...] management semantics as notificationArns.
Fixes aws/aws-cdk#5170
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Fixes #
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license