feat(remove): add a TUI for removing resources from project. - #2310
Hweinstock wants to merge 3 commits into
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Nice implementation. The screen composes cleanly from a table of picker configs, the tests use real temp directories and TestCoreClient (no fs/handler mocking), and the coverage is broad — every resource type, empty states, nested-resource parent columns, cwd-vs-seeded project resolution, cancel/confirm paths, and post-removal refresh via queryClient.setQueryData.
A few small things I checked and satisfied myself on, listed only so you know they were considered — no changes required:
gateway-connector's picker config emitsresourceType: "gateway-target"in eachRemovableResource(screen.tsx:81). That's intentional and correct: the storage model has connectors as a variant of gateway targets, andRemoveConfirmusesconfig.resourceTypefor display while passing the resource straight toremoveResource, so backend and UI stay aligned.- Middleware order (
withProjectbeforewithTuiWhenInteractiveinhandlers/project/index.ts) means runningagentcore project removeoutside a project surfaces the CLI's project-not-found error instead of opening the TUI. The TUI's own "No AgentCore project found" screen is reachable when navigating into remove from within the TUI (as exercised by the test atremove.screen.test.tsxwhere the working dir has no project). Consistent with howstatusis wired. online-insightisn't a distinct row in the picker (it sharesonlineEvalConfigswithonline-eval); this mirrors the storage model, though worth confirming that's the desired UX ifonline-insightentries ever need to be visually distinguished fromonline-evalentries in the remove list.
No telemetry gap flagged since sibling screens (add, status) don't instrument either.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2310 +/- ##
============================================
+ Coverage 97.03% 97.04% +0.01%
============================================
Files 580 581 +1
Lines 39630 39940 +310
============================================
+ Hits 38453 38761 +308
- Misses 1177 1179 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Problem
Remove is missing a TUI.
Solution
Verification
remove-tui-demo.mov