Conversation
Contributor
Author
Bug bash — imperative evaluator commands (live, sandbox account, us-west-2)Recorded with the TUI harness against a live AgentCore account. All cases verified end-to-end; the created evaluators were deleted afterward (no residue).
Baseline Bedrock create/get/update/delete unchanged and green. A screen recording of this run is archived internally (Artifactory); it is not linked here because this repository is public. |
jariy17
added this pull request to stack #2302
September 14, 2026 22:32
Support the OpenResponses judge provider on the imperative evaluator commands, matching `project add evaluator llm-as-a-judge`. Bedrock stays the default. - Shared module: modelProviderFlag, resolveModelProvider, and buildEvaluatorModelConfig, which selects the SDK modelConfig union arm. OpenResponses carries the deployment defaults (maxOutputTokens 4096, temperature 0) and omits topP to match the old CLI's project deployment. - create: register --model-provider, default Bedrock, build the correct arm. - update: make the merge provider-aware — detect and preserve the existing union arm and its tuning, overlay only supplied values, and support an explicit provider change (which requires a new --model, since model ids are not portable between provider APIs). Add --model-provider for CRUD parity.
jariy17
force-pushed
the
model-provider-imperative
branch
from
September 15, 2026 18:41
08361c7 to
1a0163c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
--model-provider(Bedrock default / OpenResponses) to the imperativeagentcore eval evaluator llm-as-a-judge createandupdatecommands, and makesupdateprovider-safe.Part 2 of 2 — stacked on #2298. Base this on #2298; it will retarget to
refactoronce #2298 merges.Changes
sharedFlags.tsx):modelProviderFlag,resolveModelProvider, andbuildEvaluatorModelConfig(picks the SDKmodelConfigunion arm). OpenResponses carriesmaxOutputTokens: 4096,temperature: 0, and omitstopPto match the old CLI's project deployment defaults.update/index.tsx,core/eval.tsx,handlers/eval/types.tsx): the merge is now provider-aware — it detects and preserves the existing union arm and its tuning (BedrockinferenceConfig, OpenResponsestemperature/topP/reasoning), overlays only supplied values, and supports an explicit provider change. Changing provider requires a new--model, since model ids are not portable between provider APIs.Why the update change matters
Before this,
updateonly understoodbedrockEvaluatorModelConfig. Once OpenResponses evaluators exist, an instructions-only update would fail, and a model update could silently convert the evaluator to Bedrock and drop its tuning.Verification
bun test .../sharedFlags.test.tsx .../core/evalEvaluatorProvider.test.tsx— 15 pass (provider resolution, arm construction, and the update-safety matrix: model-only Bedrock preserves tuning; instructions-only OpenResponses stays on the responses arm; provider switch requires a model; switch selects the correct arm without leaking the old tuning).evaluator.test.tsx— 32 pass (Bedrock path unchanged).bun run typecheck+bun run lint:checkclean; create/update--helplist both providers.Follow-ups
evaluator.test.tsxrequire recording against an account with OpenResponses access (bug-bash item).modelProvider: OpenResponsesis handled by@aws/agentcore-cdkin the generated app; deploy-time verification in the bug-bash notes.Bug-bash recording against the explore account to follow in a comment.