Conversation
Applies the router's help-group mechanism (PR #2262) to the runtime and harness commands whose flat option lists had grown past skimming. Presentation only — no flag is added, removed, or renamed, and no request changes. Grouped commands: - harness create: Configuration, Agent, Compute environment, Access, Limits - harness update: Target, Configuration, Agent, Compute environment, Access, Limits - runtime invoke: Target, Payload, Session, Authentication, Application headers, MCP, Tracing (flags reordered so each heading's flags declare contiguously) - runtime logs / harness logs: Log source, Time window, Filtering (the shared observability/logs flags carry the last two headings; only these two commands consume that handler) Headings reuse the eval vocabulary where the concept matches: Configuration holds name/execution-role-arn/tags, and update's Target is the same heading eval already uses. A command that groups its flags gets its generated -h/--help moved to "Other options:". Also trims the Parameter details section: the long-form blocks for --name, --system-prompt, and --execution-role-arn are removed (self-explanatory), and --trace-parent/--trace-state/--baggage/--trace-id gain the W3C/X-Ray format and an example they previously lacked.
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Cosmetic PR that adds helpGroup labels to flags for the large-option commands (harness create/update/logs, runtime invoke/logs, and shared observability logs). The flag() helper already supports group, and Commander renders it via Option.helpGroup, so this is straightforward metadata.
One thing worth confirming, not blocking:
- Dropped
parameterHelpentries insrc/handlers/harness/parameterHelp.tsx— thename,executionRoleArn, andsystemPromptlong-form help strings were removed and not replaced.harness create --helpno longer surfaces the--namepattern ([a-zA-Z][a-zA-Z0-9_]{0,39}) or the "when omitted, a defaultAgentCoreHarness-<name>role is provisioned" behavior for--execution-role-arn. If that was intentional (deemed self-explanatory), no action needed; otherwise please restore them or move the key details into the shortdescriptionstring.
No new tests are needed for this change (no help-output snapshots exist), and no telemetry is warranted since this is a --help presentation change. parameterHelp.name/executionRoleArn/systemPrompt are not referenced anywhere else, so removing them doesn't break other call sites.
Minor style-level inconsistencies (some group labels use const while a few are inlined literals; execution-role-arn sits alone in a "Configuration:" group in update) are not blockers.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2296 +/- ##
=========================================
Coverage 97.09% 97.09%
=========================================
Files 578 578
Lines 39639 39715 +76
=========================================
+ Hits 38486 38562 +76
Misses 1153 1153 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Applied help Groups to all commands of
agentcore runtimeandagentcore harness. We didn't add helpGroups to either get/list commands because they are simple.Before / after
--helpagentcore harness create --helpBefore
After
agentcore harness update --helpBefore
After
agentcore runtime invoke --helpBefore
After
agentcore runtime logs --helpBefore
After
agentcore harness logs --helpBefore
After