Skip to content

sfn-manage-container-task-tf: Update AWS Provider to v6 and remove leftover AWS Batch references - #3273

Open
kakakakakku wants to merge 5 commits into
aws-samples:mainfrom
kakakakakku:sfn-manage-container-task-tf
Open

sfn-manage-container-task-tf: Update AWS Provider to v6 and remove leftover AWS Batch references#3273
kakakakakku wants to merge 5 commits into
aws-samples:mainfrom
kakakakakku:sfn-manage-container-task-tf

Conversation

@kakakakakku

Copy link
Copy Markdown
Contributor

Issue #, if available:
N/A

Description of changes:
Hi😀 Thanks for the useful patterns!

To keep this pattern maintainable, I updated the AWS Provider to v6.

I also found that this pattern mentioned AWS Batch in README.md, main.tf and variables.tf, even though it does not use AWS Batch at all. These mentions were probably copied from another AWS Batch based pattern. I fixed them to match the actual implementation. I also removed the unnecessary aws_ecs_service resource because the state machine runs the Fargate task directly with ecs:runTask.sync.

Check

terraform apply completed successfully and works good.

image image

Thank you😀


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* [AWS CLI](https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2.html) installed and configured
* [Git Installed](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git)
* [AWS Serverless Application Model](https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-install.html) (AWS SAM) installed
* [Terraform](https://learn.hashicorp.com/tutorials/terraform/install-cli) with version 1.x installed (this pattern has been tested with version 1.15)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This pattern use Terraform not AWS SAM!


1. Create a new directory, navigate to that directory in a terminal and clone the GitHub repository:
```
git clone https://github.com/aws-samples/step-functions-workflows-collection

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: It's wrong repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants