test: pass --url, required by server 2.4.0 - #55
Merged
Conversation
The server exits at boot without --url as of authorizerdev/authorizer#764, so both suites would fail at container startup once the image pin moves to 2.4.0 stable. The pin is 2.4.0-rc.13 today, so this is a no-op now. Uses the in-container address rather than the mapped host port, which is only knowable after start. The difference affects generated email links and the JWT iss claim; neither suite asserts on either.
lakhansamani
added a commit
that referenced
this pull request
Aug 19, 2026
redirect_uri is validated against --url, so setting it to localhost:8080 while the suite reached a testcontainers-mapped random port made magic_link_login refuse with "Invalid redirect URI" and return no data - two failures on main since #55. Ask the OS for a free port, bind the container to it, and give the same address to --url. Also pins the test server image to 2.4.0-rc.23; rc.13 predates every change under test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
authorizerdev/authorizer#764 made
--urlmandatory — the server exits at boot without it. Both suites spawn the server through testcontainers with no--url, so every test would fail at container startup once the image pin moves to 2.4.0 stable.The pin is
2.4.0-rc.13today, which predates the requirement, so this is a no-op right now — it prevents a breakage rather than fixing a current failure.Why the in-container address
--urlis the server's own canonical address and must be passed at startup, but the testcontainers host port is only knowable after.start(). So the value is the address the server actually binds inside the container (http://localhost:8080), not the mapped port the suite dials.That difference only affects generated email links and the JWT
issclaim. Neither suite asserts on either — verified by grep: noissassertions, and no email-link parsing (the SMTP config points at ethereal but nothing reads the messages back).Verification
npx tsc --noEmitclean. Not run against a live 2.4.0 image — that needs Docker and a stable build that does not exist yet; the change is argument-only.