feat: support match_all in network ACL rules for unconditional block/allow - #1483
Open
harshithRai wants to merge 2 commits into
Open
feat: support match_all in network ACL rules for unconditional block/allow#1483harshithRai wants to merge 2 commits into
harshithRai wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1483 +/- ##
=======================================
Coverage 80.81% 80.82%
=======================================
Files 163 163
Lines 7805 7807 +2
Branches 1741 1741
=======================================
+ Hits 6308 6310 +2
Misses 797 797
Partials 700 700 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
harshithRai
marked this pull request as ready for review
September 3, 2026 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Adds support for the
match_allfield on network ACL rules, which lets a rule unconditionally match all traffic within a scope without specifying any other criteria. This backs unconditional block-all and allow-all rules.rulevariant to thenetworkACLsschema requiringaction,scope, andmatch_all. The field only acceptstrue, mirroring the API, which rejectsfalse.matchandnot_match, so the CLI fails fast on the mutually exclusive combinations the API would reject with a 400.NetworkACLalready derives from the node-auth0GetNetworkAclsResponseContenttype, which carriesmatch_all, so create, update, and dump pass it through unchanged.match_allin the resource docs with YAML and directory examples.The API gates
match_allbehind thetenant_acl_match_allfeature flag and returns a 400 if it is not enabled for the tenant. The CLI does not gate on this flag itself.Shape
A new optional
match_allfield onrule, mutually exclusive withmatch/not_match.YAML, before:
YAML, after (unconditional block-all):
Directory JSON, before:
{ "rule": { "action": { "block": true }, "scope": "tenant", "match": { "geo_country_codes": ["US"] } } }Directory JSON, after:
{ "rule": { "action": { "block": true }, "scope": "tenant", "match_all": true } }🔬 Testing
Unit tests: added schema tests covering a valid
match_all: truerule, rejection ofmatch_all: false, and rejection ofmatch_allcombined with eithermatchornot_match. Existing create, update, get, and delete tests continue to pass.Verified against a live tenant with
tenant_acl_match_allenabled, scoped to networkACLs only:match_all: truerule produced the expected plan (YAML and directory).match_allblock-all rule (YAML and directory).match_all: trueback into both YAML and directory output.match_alltomatchvia import clearedmatch_allserver-side and applied without a 400, confirming rule-type transitions work through the CLI's full-object update.📝 Checklist