Skip to content

fix(ci): gate Classic Check on published locks - #35

Merged
zoeyrose merged 7 commits into
mainfrom
fix/issue-34-classic-check-locks
Aug 26, 2026
Merged

fix(ci): gate Classic Check on published locks#35
zoeyrose merged 7 commits into
mainfrom
fix/issue-34-classic-check-locks

Conversation

@zoeyrose

Copy link
Copy Markdown
Member

Summary

Fix the Classic Check publication path so it verifies the pinned Classic
consumer's dependency lock before publishing immutable Windows candidates.
Keep candidate publication and the final smoke check on the same verified
consumer coordinates.

Implementation / behavior

  • Validate the pinned Classic revision, workflow jobs, dependency tags,
    commits, asset URLs, and SHA-256 values as one bounded consumer contract.
  • Run the dependency-availability and digest preflight before any immutable
    candidate is pushed.
  • Retain the published-digest smoke test and native Classic Check validation
    as the final consumer checks before promotion.

Validation

  • Run the repository's JSON, shell, Dockerfile, and workflow validation for
    the affected publication path.
  • Verify the preflight rejects missing or mismatched Classic dependency
    assets without publishing a candidate.
  • Run the applicable Classic Check smoke and publication checks on the final
    head; any external Classic lock prerequisite remains explicitly reported.

Limitations / follow-up

The Classic Content lock refresh tracked by classic#458
is a separate cross-repository delivery. This change does not modify Classic
or the unrelated Sound follow-up in classic#457.

Closes #34

@zoeyrose zoeyrose moved this to Review in Atrinik work Aug 24, 2026
@zoeyrose
zoeyrose marked this pull request as ready for review August 25, 2026 22:19
@zoeyrose
zoeyrose merged commit cc364cb into main Aug 26, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in Atrinik work Aug 26, 2026
@zoeyrose
zoeyrose deleted the fix/issue-34-classic-check-locks branch August 26, 2026 04:40
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

fix(ci): align Classic Check smoke inputs with published locks

1 participant