fix: prevent EOF diagnostic panic without trailing newline - #379
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files ending in an incomplete statement without a trailing newline, such as
var myvar, panic while rendering the EOF diagnostic. Translation units append a synthetic newline, but the diagnostic renderer previously read the shorter original source.Apply the same trailing-newline normalization to diagnostic snippets so the error span remains in bounds. The source file is unchanged. This also handles included files and missing-include diagnostics without a final newline.
Validated on macOS with 13 CLI cases, including both reported reproducers, included files, CRLF, Unicode strings, and valid input. Both reproducers now report an EOF error and exit with code 1. All 12 existing tests and
cargo check --offlinepass. CLI checks usedstd = "0.0.0"to avoid unrelated network initialization.