rt3573 fails to compile in latest kernel

[MRNGSTAR]

First off appreciate all your hard work. I have successfully compiled and used your package to run our RT3573 adapter (trendnet 684usb) on x64 bit kernels all the way up to 3.12 final. However it no longer compiles on 3.12,1 or any of the 3.13 rc1 to rc3 releases and was just wondering if you were aware. This is what I get following the make command not sure if this helps in anyway:

home/xxxxx/driversx/os/linux/../../os/linux/rt_linux.c:1138:20: error: incompatible types when assigning to type ‘int’ from type ‘kuid_t’
/home/xxxxx/driversx/os/linux/../../os/linux/rt_linux.c:1139:20: error: incompatible types when assigning to type ‘int’ from type ‘kgid_t’
make[2]: *** [/home/xxxx/driversx/os/linux/../../os/linux/rt_linux.o] Error 1
make[1]: *** [module/home/xxxxx/driversx/os/linux] Error 2
make[1]: Leaving directory `/usr/src/linux-headers-3.13.0-031300rc3-generic'
make: *** [LINUX] Error 2

Again thanks for all your hard work

[jerseysal]

Thanks for the heads up. I will research and get back to you.

Be well...

On Sat, December 7, 2013 10:32, MRNGSTAR wrote:

First off appreciate all your hard work. I have successfully compiled and
used your package to run our RT3573 adapter (trendnet 684usb) on x64 bit
kernels all the way up to 3.12 final. However it no longer compiles on
3.12,1 or any of the 3.13 rc1 to rc3 releases and was just wondering if
you were aware. This is what I get following the make command not sure if
this helps in anyway:

home/xxxxx/driversx/os/linux/../../os/linux/rt_linux.c:1138:20: error:
incompatible types when assigning to type ‘int’ from type ‘kuid_t’
/home/xxxxx/driversx/os/linux/../../os/linux/rt_linux.c:1139:20: error:
incompatible types when assigning to type ‘int’ from type ‘kgid_t’
make[2]: *** [/home/xxxx/driversx/os/linux/../../os/linux/rt_linux.o]
Error 1
make[1]: *** [module/home/xxxxx/driversx/os/linux] Error 2
make[1]: Leaving directory
`/usr/src/linux-headers-3.13.0-031300rc3-generic'
make: *** [LINUX] Error 2

Again thanks for all your hard work

---

Reply to this email directly or view it on GitHub:
#8

Sal Di Sciascio

"I think; therefore I am." - Rene DesCartes
"I yam wot I yam 'n' 'at's all wot I yam." - Popeye the Sailorman

[ashaffer]

I was not aware of this. I'll try to look into it ASAP. Should be a straightforward fix.

[JohnnySSH]

Hi, I'm also experiencing the same issue with my Edimax wireless usb adaptor.

It kinda works with the integrated rt28xx module:

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=637065267eab4817c0b06cbf3c7fc80842acab99

However.... it's not stable! The rt3573sta driver with ashaffer patch was brilliant; no disconnects or chip resets and also 5GHz frequency worked really well.... The current integrated kernel rt28xx module disconnects all the time and when analyzing via "wavemon" I don't get the output that the rt3573sta-ashaffer-patch driver had. Mainly SNR ratio, Noise level that kinda stuff....

[jimerickson]

still doesn't compile on ubuntu 14.04 with the 3.13.0-5-generic kernel.

[MRNGSTAR]

I'm wondering if the integrated rt28xx module mentioned by JohnnySSH is actually somehow preventing the rt3573sta-ashaffer from compiling correctly. If I get the time maybe I'll try removing the rt28xx module from the new kernel and attempt to recompile the rt3573sta-ashaffer unless someone more ambitious beats me to it.

[jimerickson]

can only get the rt2800usb driver to work on 2.4 ghz on ubuntu 14.04

[MRNGSTAR]

Okay I got ambitious I tried removing the rt2x00 module (not elegantly I should add) from the new kernel restarted then tried to compile the ashaffer rt3573sta the bottom line is it still doesn't work. So its beyond my current knowledge/skill set to get it working in the newer kernel my failed attempt was with 3.14rc2. I went back to 3.12 final and will probably stay put on that kernel until ashaffer rt3573 is patched to work with the newer kernels

[JohnnySSH]

I did the same in Archlinux.... I ran rmmod rt2x00 then tried installing the Ashaffer patch. It didn't work :-(

Currently I reverted back to the LTS kernel which for Arch is version: 3.10.31-1

For some reason the Ashaffer patch doesn't work on the Arch stock kernels? I did manage to install the standard rt3573sta driver which am using now. Though I can feel that it's not the same as as the "patched" version.

Using the Lqx kernel everything was fine however, now none build on it.

If the ashaffer patched version could be incorporated into the mainstream kernel that would be fantastic as the rt2x00 module doesn't even seem to be 3x3 antenna compatible either meaning my signal quality is far less using that, it's probably able to use the 1x1 or 2x2 antenna array but the extra is a no-go.

[MRNGSTAR]

Well just call me stubborn I tried again with 3.14 rc5 messing around with lsmod, blacklist alll with no joy. Could it be as simple as just needing a change in gcc version or command line directing which version needs to be used to compile and if so anyone out there who really knows what they are doing able to help out?

[MRNGSTAR]

ashaffer, just checking to see if you have made any progress at all in identifying a fix for this and to let you know that I would be happy to help test if needed although be advised unfortunately my skills are admittedly not particularly great.

[ashaffer]

@MRNGSTAR Sorry for not responding in so long. I actually stopped using the driver because it seemed to still have intermittent issues.

I'll see if I can get it to compile on the latest ubuntu kernel when I get home from work, but I may or may not have time to see if it actually operates correctly.

If you guys are getting it to load at all and it's not working, would you mind posting the output of dmesg if possible? There is also a way to compile the driver with elevated log levels so your dmesg output is more verbose. I'll try to re-figure that out for you again so you can get better debugging information.

[MRNGSTAR]

On 04/07/2014 07:01 PM, ashaffer wrote:

@MRNGSTAR https://github.com/MRNGSTAR Sorry for not responding in so
long. I actually stopped using the driver because it seemed to still
have intermittent issues.

I'll see if I can get it to compile on the latest ubuntu kernel when I
get home from work, but I may or may not have time to see if it
actually operates correctly.

If you guys are getting it to load at all and it's not working, would
you mind posting the output of dmesg if possible? There is also a way
to compile the driver with elevated log levels so your dmesg output is
more verbose. I'll try to re-figure that out for you again so you can
get better debugging information.

—
Reply to this email directly or view it on GitHub
#8 (comment).

@ashaffer Hey no worries, your driver works the absolute best as far as
I'm concerned and I think quite a few others share my opinion if you are
having intermittent issues it might be just be your wireless router.
Your driver is the only reason I'm staying on kernel 3.12. I don't think
anyone has been able to get it to load on the new kernels as it pretty
much totally fails to compile I'm just glad your still willing to work
on it :-)

[RD777]

@MRNGSTAR Hello there, if you want a quick fix on the compilation and since I can see you're using a kernel > 3.0 well the fix would be to do the following:
Comment out the lines 1137,1138,1139 in rt3573sta/os/linux/rt_linux.c

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,29)
pOSFSInfo->fsuid = current->fsuid;
pOSFSInfo->fsgid = current->fsgid;
current->fsuid = current->fsgid = 0;
//#else
// pOSFSInfo->fsuid = current_fsuid() ;
// pOSFSInfo->fsgid = current_fsgid() ;
#endif

and make install, modprobe, etc.

[MRNGSTAR]

On 04/09/2014 03:26 PM, RD777 wrote:

Hello there, if you want a quick fix on the compilation and since I
can see you're using a kernel > 3.0 well the fix would be to do the
following:
Comment out the lines 1137,1138,1139 in rt3573sta/os/linux/rt_linux.c

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,29)
pOSFSInfo->fsuid = current->fsuid;
pOSFSInfo->fsgid = current->fsgid;
current->fsuid = current->fsgid = 0;
//#else
// pOSFSInfo->fsuid = current_fsuid() ;
// pOSFSInfo->fsgid = current_fsgid() ;
#endif

and make install, modprobe, etc.

—
Reply to this email directly or view it on GitHub
#8 (comment).

YEAH !!!!!!!!!!! IT WORKS!!!!!!! ITS ALIVE!!!!!!! THANK YOU
!!!!!!!!THANK YOU!!!!!!!!!

[RD777]

@MRNGSTAR Haha no problem!