fix(account): offer only ID token providers on the ID token session - #13759
Merged
Merged
Conversation
The route described `apple, google` while whitelisting all 52 OAuth providers and generating the shared `OAuthProvider` enum, so an SDK offered every provider on this method and the docs example was `amazon`. Sending any of them passed validation and then failed in the action with PROJECT_PROVIDER_UNSUPPORTED. The whitelist now holds the providers that configure `idToken`, and the parameter generates its own `IdTokenProvider` enum. The mock providers stay whitelisted, since the e2e suites sign in with them, and the generated enum keeps excluding them, so it reads `apple, google`.
Contributor
|
Meldiron
approved these changes
Sep 18, 2026
✨ Benchmark resultsComparing
Per-scenario breakdown & investigation detailsMetrics below reflect the current branch (after). Δ P95 compares against the base.
Top API waits (after)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /account/sessions/id-tokenonly works with Apple and Google, but theproviderparameter whitelisted all 52 OAuth providers and generated the sharedOAuthProviderenum. SDKs offered every provider on this method, the docs example wasamazon, and sending one passed validation and then failed in the action withPROJECT_PROVIDER_UNSUPPORTED.The whitelist is now the providers that configure
idToken, and the parameter gets its ownIdTokenProviderenum.In the published document, the
providerproperty goes from this:to this:
The example follows the first whitelist entry (
OpenAPI3.php,$validator->getList()[0]), so it moves fromamazontoappleon its own.The mock providers stay whitelisted because the e2e account suites sign in with them; the generated enum still excludes them, which is why the branches come out as
apple, google. The separate enum name is needed becauseOAuthProvideris generated elsewhere with the full set.Found while reviewing appwrite/specs#114, which publishes this route for the first time. The "before" block above is copied from that document.