Skip to content

fix: -ac Level:Version rejected — commons-cli 1.6.0 drops the ':' separator #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valandi merged 1 commit into from
Aug 13, 2026
Merged

fix: -ac Level:Version rejected — commons-cli 1.6.0 drops the ':' separator #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/com/applitools/imagetester/lib/EyesFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,10 @@ public EyesFactory imageCut(String[] cutArgs) {
public EyesFactory accSettings(String[] settings) {
if (settings == null)
return this;
// commons-cli 1.6.0 ignores valueSeparator(':') on options with optionalArg(true),
// so "-ac AA:WCAG_2_1" arrives here as one unsplit token — split it ourselves.
if (settings.length == 1 && settings[0].contains(":"))
settings = settings[0].split(":", 2);
AccessibilityLevel level = AccessibilityLevel.AA;
AccessibilityGuidelinesVersion version = AccessibilityGuidelinesVersion.WCAG_2_0;
if (settings.length > 2)
Expand Down
22 changes: 22 additions & 0 deletions src/test/java/com/applitools/imagetester/EyesFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import com.applitools.imagetester.lib.EyesFactory;
import com.applitools.imagetester.lib.Logger;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.DefaultParser;
import org.junit.Test;
import static org.junit.Assert.*;

Expand Down Expand Up @@ -64,6 +66,26 @@ public void accSettings_null_isNoOp() {
assertNotNull(factory);
}

@Test
public void accSettings_combinedLevelColonVersionToken_enablesValidation() {
EyesFactory factory = createFactory().accSettings(new String[]{"AA:WCAG_2_1"});
assertTrue(factory.hasAccessibilityValidation());
}

@Test
public void accSettings_combinedTokenWithBlankLevel_enablesValidation() {
EyesFactory factory = createFactory().accSettings(new String[]{":WCAG_2_1"});
assertTrue(factory.hasAccessibilityValidation());
}

@Test
public void accSettings_cliParsedColonSeparatedValue_enablesValidation() throws Exception {
CommandLine cmd = new DefaultParser().parse(ImageTester.getOptions(),
new String[]{"-ac", "AA:WCAG_2_1"});
EyesFactory factory = createFactory().accSettings(cmd.getOptionValues("ac"));
assertTrue(factory.hasAccessibilityValidation());
}

@Test(expected = IllegalArgumentException.class)
public void accSettings_moreThanTwoValues_throws() {
createFactory().accSettings(new String[]{"AA", "WCAG_2_1", "extra"});
Expand Down
Loading