Skip to content

fix(webdriver): normalize orientation value to uppercase in setter #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dor-bl wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −1
Open

fix(webdriver): normalize orientation value to uppercase in setter #1308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appium/webdriver/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ def orientation(self, value: str) -> None:
"""
allowed_values = ['LANDSCAPE', 'PORTRAIT']
if value.upper() in allowed_values:
self.execute(Command.SET_SCREEN_ORIENTATION, {'orientation': value})
self.execute(Command.SET_SCREEN_ORIENTATION, {'orientation': value.upper()})
else:
raise WebDriverException("You can only set the orientation to 'LANDSCAPE' and 'PORTRAIT'")

Expand Down
15 changes: 15 additions & 0 deletions test/unit/webdriver/webdriver_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,21 @@ def test_orientation_setter(self):
'orientation': 'PORTRAIT',
}

@httpretty.activate
def test_orientation_setter_normalizes_case(self):
driver = android_w3c_driver()
httpretty.register_uri(httpretty.POST, appium_command('/session/1234567890/orientation'), body='{"value": ""}')

driver.orientation = 'landscape'
assert get_httpretty_request_body(httpretty.last_request()) == {
'orientation': 'LANDSCAPE',
}

driver.orientation = 'portrait'
assert get_httpretty_request_body(httpretty.last_request()) == {
'orientation': 'PORTRAIT',
}

@httpretty.activate
def test_orientation_setter_invalid(self):
driver = android_w3c_driver()
Expand Down
Loading