Skip to content

fix(computing-unit): repair the owner-avatar accessor in the spec - #7633

Merged
aglinxinyuan merged 1 commit into
apache:mainfrom
aglinxinyuan:fix/computing-unit-owner-avatar-rename
Aug 13, 2026
Merged

fix(computing-unit): repair the owner-avatar accessor in the spec#7633
aglinxinyuan merged 1 commit into
apache:mainfrom
aglinxinyuan:fix/computing-unit-owner-avatar-rename

Conversation

@aglinxinyuan

@aglinxinyuan aglinxinyuan commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

main does not compile. Any PR whose build / amber or build / amber-integration jobs run after this landed fails on it regardless of what the PR itself touches — #7631 is an example, where the only change is four tests in an unrelated module's spec.

Scoping that honestly: PRs whose amber jobs ran before the breakage still show green and would fail on re-run, and frontend-labelled PRs skip the amber stack, so this is "every amber run from now until it is fixed" rather than "every open PR is red today".

ComputingUnitManagingResourceSpec asserts on DashboardWorkflowComputingUnit.ownerGoogleAvatar, but the field is named ownerAvatar, so ComputingUnitManagingService / Test fails with two "value ownerGoogleAvatar is not a member" errors.

Two PRs raced to produce it: #7563 renamed the field to ownerAvatar, while #7580 added assertions written against the old name. Each was green against its own base, and the combination is what breaks — the kind of thing per-PR CI cannot see when two PRs touch different files.

This renames the two accessor calls. Nothing else changes.

How was this PR tested?

Confirmed the breakage is real and that this is the whole of it, by stashing the change and re-running on otherwise-clean main:

sbt "ComputingUnitManagingService/Test/compile"
Result
unpatched main exit 1, exactly 2 × value ownerGoogleAvatar is not a member
with this change exit 0, compiles clean

Then the spec itself:

sbt "ComputingUnitManagingService/testOnly org.apache.texera.service.resource.ComputingUnitManagingResourceSpec"
[info] Total number of tests run: 31
[info] Tests: succeeded 31, failed 0, canceled 0, ignored 0, pending 0

All 31 pass, so the assertions were correct about the value and only the accessor name was stale. Test/scalafmtCheck and Test/scalafix --check both pass.

Any related issues, documentation, discussions?

Closes #7632

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Opus 5)

main does not compile. ComputingUnitManagingResourceSpec asserts on
DashboardWorkflowComputingUnit.ownerGoogleAvatar, but that field is named
ownerAvatar - so ComputingUnitManagingService/Test fails with two "value
ownerGoogleAvatar is not a member" errors, which takes down every amber
and amber-integration job.

Two PRs raced to produce it: apache#7563 renamed the field to ownerAvatar while
apache#7580 added assertions written against the old name, and each was green
against its own base.

Renames the two accessor calls. Nothing else changes; the spec's 31 tests
pass, so the assertions were correct about the value all along.
Copilot AI lite review requested due to automatic review settings August 13, 2026 06:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added fix platform Non-amber Scala service paths labels Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Backport auto-label report

This fix: PR was checked against each actively-supported release branch. release/* labels drive the post-merge backport, so add or remove one to change where this fix lands.

Release branch Analysis
⚠️ release/v1.2 Not labeled automatically — none of the files this PR modifies exist on this branch (computing-unit-managing-service/src/test/scala/org/apache/texera/service/resource/ComputingUnitManagingResourceSpec.scala). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. Please check and add release/v1.2 by hand if this fix should be backported here.

Auto-label run.

@github-actions

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @eugenegujing
    You can notify them by mentioning @eugenegujing in a comment.

@codecov-commenter

codecov-commenter commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.40%. Comparing base (86dd852) to head (6e5ccc1).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7633      +/-   ##
============================================
+ Coverage     89.29%   89.40%   +0.10%     
- Complexity     4359     4375      +16     
============================================
  Files          1177     1177              
  Lines         46831    46831              
  Branches       5224     5224              
============================================
+ Hits          41817    41867      +50     
+ Misses         3269     3217      -52     
- Partials       1745     1747       +2     
Flag Coverage Δ *Carryforward flag
access-control-service 70.00% <ø> (ø)
agent-service 98.62% <ø> (ø) Carriedforward from 86dd852
amber 85.74% <ø> (ø) Carriedforward from 86dd852
computing-unit-managing-service 72.46% <ø> (+12.07%) ⬆️
config-service 77.31% <ø> (ø)
file-service 68.90% <ø> (ø)
frontend 90.59% <ø> (ø) Carriedforward from 86dd852
notebook-migration-service 78.89% <ø> (ø)
pyamber 97.57% <ø> (ø) Carriedforward from 86dd852
workflow-compiling-service 57.89% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aglinxinyuan
aglinxinyuan enabled auto-merge August 13, 2026 06:45

@mengw15 mengw15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aglinxinyuan
aglinxinyuan added this pull request to the merge queue Aug 13, 2026
Merged via the queue into apache:main with commit eefd860 Aug 13, 2026
37 checks passed
@aglinxinyuan
aglinxinyuan deleted the fix/computing-unit-owner-avatar-rename branch August 13, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix platform Non-amber Scala service paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main does not compile: spec asserts on a renamed owner-avatar field

4 participants