fix(computing-unit): repair the owner-avatar accessor in the spec - #7633
Merged
aglinxinyuan merged 1 commit intoAug 13, 2026
Merged
Conversation
main does not compile. ComputingUnitManagingResourceSpec asserts on DashboardWorkflowComputingUnit.ownerGoogleAvatar, but that field is named ownerAvatar - so ComputingUnitManagingService/Test fails with two "value ownerGoogleAvatar is not a member" errors, which takes down every amber and amber-integration job. Two PRs raced to produce it: apache#7563 renamed the field to ownerAvatar while apache#7580 added assertions written against the old name, and each was green against its own base. Renames the two accessor calls. Nothing else changes; the spec's 31 tests pass, so the assertions were correct about the value all along.
Contributor
Backport auto-label reportThis
|
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7633 +/- ##
============================================
+ Coverage 89.29% 89.40% +0.10%
- Complexity 4359 4375 +16
============================================
Files 1177 1177
Lines 46831 46831
Branches 5224 5224
============================================
+ Hits 41817 41867 +50
+ Misses 3269 3217 -52
- Partials 1745 1747 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aglinxinyuan
enabled auto-merge
August 13, 2026 06:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
maindoes not compile. Any PR whosebuild / amberorbuild / amber-integrationjobs run after this landed fails on it regardless of what the PR itself touches — #7631 is an example, where the only change is four tests in an unrelated module's spec.Scoping that honestly: PRs whose amber jobs ran before the breakage still show green and would fail on re-run, and frontend-labelled PRs skip the amber stack, so this is "every amber run from now until it is fixed" rather than "every open PR is red today".
ComputingUnitManagingResourceSpecasserts onDashboardWorkflowComputingUnit.ownerGoogleAvatar, but the field is namedownerAvatar, soComputingUnitManagingService / Testfails with two "value ownerGoogleAvatar is not a member" errors.Two PRs raced to produce it: #7563 renamed the field to
ownerAvatar, while #7580 added assertions written against the old name. Each was green against its own base, and the combination is what breaks — the kind of thing per-PR CI cannot see when two PRs touch different files.This renames the two accessor calls. Nothing else changes.
How was this PR tested?
Confirmed the breakage is real and that this is the whole of it, by stashing the change and re-running on otherwise-clean
main:mainvalue ownerGoogleAvatar is not a memberThen the spec itself:
All 31 pass, so the assertions were correct about the value and only the accessor name was stale.
Test/scalafmtCheckandTest/scalafix --checkboth pass.Any related issues, documentation, discussions?
Closes #7632
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)