WW-5732 fix(jasperreports7): match the report format case-insensitively - #1922
Merged
Conversation
lukaszlenart
marked this pull request as ready for review
September 12, 2026 10:08
The exporter providers are registered under the lower-case names in JasperReport7Constants and the container lookup is exact, so the upper-case "CSV" from the class Javadoc example (and from any config migrated from the 6.x plugin, whose constants are upper-case) failed with "No exporter found for format: CSV". The result now retries the lookup with the lower-cased name, so a custom provider registered under a mixed-case name keeps working while csv, Csv and CSV all resolve to the bundled one. The example uses the canonical lower-case spelling. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lukaszlenart
force-pushed
the
WW-5732-format-case
branch
from
September 12, 2026 10:18
2c98c0b to
3a6b02d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WW-5732
The exporter providers are registered under the lower-case names from
JasperReport7Constantsand the container lookup is exact, so the upper-caseCSVin the class Javadoc example — and in any config migrated from the 6.x plugin, whose constants are upper-case — failed withNo exporter found for format: CSV.JasperReport7Resultnow looks the provider up by the configured name first and, when nothing is registered under it, by its lower-cased form (Locale.ROOT).csv,CsvandCSVall select the bundled provider, while a custom provider registered under a mixed-case bean name keeps precedence. TheContent-Dispositionfilename keeps the configured spelling, as before. Javadoc example switched tocsvand theformatbullet notes the case-insensitive match.Test
testFormatLookupIsCaseInsensitive(setFormat("CSV")) failed with the exception above before the change.🤖 Generated with Claude Code