WW-5731 fix(jasperreports7): stop using the field delimiter as the CSV record delimiter - #1921
Merged
Merged
Conversation
…V record delimiter JasperReport7CsvExporterProvider set both the field and the record delimiter to the configured delimiter, so every CSV export came out as a single line with the rows joined by "," (or whatever struts.jasperReport7.csv.defaultDelimiter / getCsvDelimiter returned). Only the field delimiter is configurable, as in the 6.x plugin; records are separated by JasperReports' default newline again. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WW-5731
JasperReport7CsvExporterProviderset the configured delimiter as both the field and the record delimiter, so every CSV export came out as a single line with the rows joined by,(or whateverstruts.jasperReport7.csv.defaultDelimiter/JasperReport7Aware.getCsvDelimiterreturned). Only the field delimiter is meant to be configurable — as in the 6.x plugin, which setsFIELD_DELIMITERalone — so thesetRecordDelimitercall is dropped and JasperReports' default newline applies.Test
testCsvRecordsAreSeparatedByNewlinesuses;as the field delimiter and two rows; before the fix the export wasQux Report;Hello Foo Bar!;Hello Baz Qux!;, now it is three lines.🤖 Generated with Claude Code