HDDS-15394. Sequential Reader of from and to snapshots for full snapshot diff. - #11083
Draft
SaketaChalamchala wants to merge 2 commits into
Draft
HDDS-15394. Sequential Reader of from and to snapshots for full snapshot diff.#11083SaketaChalamchala wants to merge 2 commits into
SaketaChalamchala wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Developed with the help of Cursor AI.
This PR is intended as the foundation for a more efficient snapshot diff (HDDS-9154).
Baseline full diff performs random reads against snapshot DBs and holds large in-memory maps. The optimized design replaces that with:
Table<byte[], byte[]>) soSnapshotDiffValueParseroperates on exact persisted protobuf bytes (no decode/re-encode round trip). Scan order: file/key tables first, then directory tables (FSO). Each table pair runs to-side, then from-side.updateID > fromSnapshotDbTxSequenceNumber. Rows with missing, zero, orDEFAULT_OM_UPDATE_ID (-1)are always candidates (conservative fallback).{jobId}-new-list,{jobId}-old-list— keyed by objectId{jobId}-to-edges,{jobId}-from-edges— FSO directory edges (parentId,objectId) →name{jobId}-cand-ids— spill target when the in-memory diff-candidate set exceeds the configured limitparentId,name,isDir,signature) (shared with the future DAG diff sequential reader).ozone.om.snapshot.diff.max.in.memory.entries.per.job(default 1M) bounds the in-memory diff-candidate set before spill to RocksDB.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15394
(Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Unit Tests.