Skip to content

HDDS-16244. Remove redundant RPC metadata from SCMSecurityProtocol - #11079

Open
echonesis wants to merge 1 commit into
apache:masterfrom
echonesis:HDDS-16244
Open

HDDS-16244. Remove redundant RPC metadata from SCMSecurityProtocol#11079
echonesis wants to merge 1 commit into
apache:masterfrom
echonesis:HDDS-16244

Conversation

@echonesis

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

SCMSecurityProtocol duplicated the protocol version and Kerberos metadata already defined by SCMSecurityProtocolPB, which is the interface used by Hadoop RPC.

This PR:

  • removes the redundant versionID and @KerberosInfo annotation from SCMSecurityProtocol;
  • keeps the RPC metadata in SCMSecurityProtocolPB;
  • adds a regression test verifying the protocol name, protocol version, and SCM Kerberos principal exposed by the PB protocol.

This consolidates the RPC metadata in the protocol interface where it is consumed and prevents the duplicated definitions from diverging.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-16244

How was this patch tested?

Local Test

mvn -pl :hdds-server-framework -am test \
      -Dtest=TestSCMSecurityProtocolPB \
      -Dsurefire.failIfNoSpecifiedTests=false \
      -DskipShade -DskipRecon -DskipDocs

mvn -pl :ozone-integration-test test \
      -Dtest=TestSecureOzoneCluster#testSecureScmAndOmStartupAndAccessControl \
      -DskipShade -DskipRecon -DskipDocs

GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/32463288850

Generated-by: Codex (GPT-5)

@chihsuan chihsuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! @echonesis +1 LGTM

cc @chungen0126

@szetszwo szetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

There was a test failure but did not seem related. Let's rerun it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants