Skip to content

HDDS-16238. Latency metrics for internal OM requests are not populated - #11072

Open
errose28 wants to merge 3 commits into
apache:masterfrom
errose28:worktree/purgekey-metrics
Open

HDDS-16238. Latency metrics for internal OM requests are not populated#11072
errose28 wants to merge 3 commits into
apache:masterfrom
errose28:worktree/purgekey-metrics

Conversation

@errose28

@errose28 errose28 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

The OM's ProtocolMessageMetrics is only used in the server side translator. This captures end-to-end latency for all client facing requests (like RenameKey), but not for internal OM requests submitted directly to Ratis by background services (like PurgeKeys). This causes latency metrics for internal requests to always be 0.

This PR wires the metrics to OzoneManagerRatisUtils#submitRequest as well to capture latency of requests submitted directly to the Ratis server.

What is the link to the Apache JIRA

HDDS-16238

How was this patch tested?

  • Unit tests added for OzoneManagerRatisUtils and all existing background services.
  • Green CI on my fork.

@errose28

Copy link
Copy Markdown
Contributor Author

cc @ptlrs @yandrey321

@yandrey321 yandrey321 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@errose28
errose28 marked this pull request as ready for review August 21, 2026 15:28

@rich7420 rich7420 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
it's a clean one
thanks for the patch @errose28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants