HDDS-16229. Add RocksDB multiGetSkipCache for batched table reads. - #11068
Draft
SaketaChalamchala wants to merge 2 commits into
Draft
HDDS-16229. Add RocksDB multiGetSkipCache for batched table reads.#11068SaketaChalamchala wants to merge 2 commits into
SaketaChalamchala wants to merge 2 commits into
Conversation
Plumb RocksDB multiGetAsList through RocksDatabase, RDBTable, and TypedTable.multiGetSkipCache for skip-cache batch point lookups. Co-authored-by: Cursor <cursoragent@cursor.com>
SaketaChalamchala
force-pushed
the
HDDS-16229
branch
from
August 20, 2026 00:31
ae03767 to
77294df
Compare
swamirishi
requested changes
Aug 20, 2026
swamirishi
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the patch @SaketaChalamchala this is a good improvement to have.
| } | ||
|
|
||
| @Override | ||
| public List<VALUE> multiGetSkipCache(List<KEY> keys) |
Contributor
There was a problem hiding this comment.
Please implement CodeBuffer based multiGets as well otherwise the GC pressure on memory would be bad
You would need to implement a similar function like
to ensure the value which didn't fit in the first multiget should be called again with a resized CodecBuffer size.
So the first call should do a multiGet with all CodecBuffer keys and based on the status list returned we need to call multiget again for the ones which didn't fit in the initial fit and collate the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RocksDB
MultiGetsupport throughRocksDatabase,RDBTable, andTypedTableon a skip-cache path. Callers can batch point lookups in one RocksDB call instead of loopingget()/getSkipCache().Added
multiGetwithCodecBufferinTypedTable.Missing keys return null at the matching list index; order matches the input key list.
Out of scope (follow-ups): cache-aware Table.multiGet, batch metrics, call-site adoption.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16229
How was this patch tested?
Unit Tests