Correct ontology schema's $id field - #372
Merged
Merged
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates the ontology JSON Schema identifier to avoid $id collision with the main ossie-schema.json, which was causing $ref resolution issues in validators.
Changes:
- Change ontology schema
$idfrom.../ossie-schema.jsonto.../ontology.jsonto prevent incorrect self-resolution of refs
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jbonofre
previously approved these changes
Sep 9, 2026
jbonofre
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the
$idof the ontology schema fromhttps://github.com/apache/ossie/core-spec/ossie-schema.jsontohttps://github.com/apache/ossie/core-spec/ontology.json.ossie-schema.json is already taken by the main schema, which is also referenced in the ontology schema (
properties.ai_context.$ref). This reference resolves incorrectly to the ontology schema (this JSON file), breaking validators. Thesemantic_modelref is broken in the same way.Related Issues
N/A
Checklist
Ontology
ontology/are consistent with spec changesTests
pytest/ CI green)Compliance