Skip to content

Correct ontology schema's $id field - #372

Merged
jbonofre merged 2 commits into
apache:mainfrom
NeverBlink-OSS:piotr/fix-ontology-id
Sep 9, 2026
Merged

Correct ontology schema's $id field#372
jbonofre merged 2 commits into
apache:mainfrom
NeverBlink-OSS:piotr/fix-ontology-id

Conversation

@Ostrzyciel

Copy link
Copy Markdown
Contributor

Summary

Change the $id of the ontology schema from https://github.com/apache/ossie/core-spec/ossie-schema.json to https://github.com/apache/ossie/core-spec/ontology.json.

ossie-schema.json is already taken by the main schema, which is also referenced in the ontology schema (properties.ai_context.$ref). This reference resolves incorrectly to the ontology schema (this JSON file), breaking validators. The semantic_model ref is broken in the same way.

Related Issues

N/A

Checklist

Ontology

  • Ontology changes in ontology/ are consistent with spec changes
  • New or modified terms are defined and documented

Tests

  • All existing tests pass (pytest / CI green)

Compliance

  • ASF license headers are present on all new source files
  • No third-party dependencies are added without PMC/IPMC approval

Copilot AI lite review requested due to automatic review settings September 9, 2026 11:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Updates the ontology JSON Schema identifier to avoid $id collision with the main ossie-schema.json, which was causing $ref resolution issues in validators.

Changes:

  • Change ontology schema $id from .../ossie-schema.json to .../ontology.json to prevent incorrect self-resolution of refs

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread ontology/ontology.json Outdated
jbonofre
jbonofre previously approved these changes Sep 9, 2026
Comment thread ontology/ontology.json Outdated
@jbonofre
jbonofre merged commit b5d8698 into apache:main Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants