Convert ontology converter to UV based - #368
Conversation
|
@vmihalovski mind take a look as well? |
There was a problem hiding this comment.
🟡 Changes recommended
The updated README includes incomplete/OS-specific setup guidance and an example that runs python outside the uv environment, and the CI uv installation method is unpinned and should be made deterministic.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR migrates the converters/ontology package from a pip-tools-generated requirements.lock workflow to an uv-managed workflow, aligning the ontology converter with the other Python converters in this repository.
Changes:
- Replace
requirements.lockwith a committeduv.lockand update the ontology converter’s dependency metadata. - Update the ontology converter README to use
uv sync/uv lockand adduv run pytestinstructions. - Update the ontology converter CI workflow to install uv and run tests via
uv.
File summaries
| File | Description |
|---|---|
| converters/ontology/uv.lock | Adds uv’s lockfile for deterministic dependency resolution. |
| converters/ontology/requirements.lock | Removes the old pip-tools lockfile. |
| converters/ontology/README.md | Updates contributor setup/test instructions to uv-based workflow. |
| converters/ontology/pyproject.toml | Adds uv + hatchling configuration and moves dev deps into dependency groups. |
| .github/workflows/converter-ontology-ci.yml | Switches CI dependency installation and test execution to uv. |
Review details
- Files reviewed: 3/5 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: Install uv | ||
| run: | | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| echo "${HOME}/.local/bin" >> "${GITHUB_PATH}" | ||
|
|
There was a problem hiding this comment.
This is to match to existed GH workflow. I will create a follow up PR for this.
| - [uv](https://docs.astral.sh/uv/) — Python package and dependency manager | ||
|
|
||
| Install pyenv if you don't have it: | ||
| Install uv if you don't have it: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
This is to match to existed converters as well where team agreed to use uv based project management.
| SNOWFLAKE_DATABASE_NAME=MY_DB SNOWFLAKE_SCHEMA_NAME=MY_SCHEMA \ | ||
| python scripts/palantir_to_ossie.py path/to/palantir_export.zip | ||
| ``` | ||
|
|
||
| ## Deactivating the environment | ||
| ## Running the tests |
There was a problem hiding this comment.
This is expected as well.
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
LGTM, I think it would be great to "fix" the examples.
@MonkeyCanCode I’m on vacation this week and will be back on Monday. Would you mind postponing the merge of this PR until next week? I’d like to test it with our other repo, which depends on this one, before we merge it. Thank you in advance. |
Summary
This PR converted ontology converter to UV based and aligned with rest of the python based converters/tooling in this repo.
Related Issues
Checklist
Specification
core-spec/and follow the existing structureOntology
ontology/are consistent with spec changesConverters
converters/is updated to reflect spec or ontology changesValidation
validation/are updated if the spec changedDocumentation
docs/is updated to reflect any user-facing changesCONTRIBUTING.mdis updated if the contribution process changedExamples
examples/are added or updated for any new spec constructs or converter supportTests
pytest/ CI green)Compliance