netutils/paho_mqtt: improvements for use as a dependency for other packages - #3749
Merged
Conversation
The bundled patch still contains an MQTTPacket.h hunk for a bool typedef that no longer exists in Paho 1.3.15. Make and CMake both hide the resulting rejection, allowing a partially patched source tree to be compiled. Remove the stale hunk and make patch failures fatal. The Make context target also allows VersionInfo.h generation to race source extraction under parallel builds. Make the generated header depend on the extraction target so the input template is present first. The publisher and subscriber samples live below src/samples but include public headers from src. Add the Paho source include directory to the Make flags, matching the CMake targets, so CONFIG_UTILS_MQTT5 builds both utilities. Finally, define distclean independently of whether the downloaded tree exists when Make parses the file. Remove package-owned archives and sources while preserving a developer Git checkout, and ignore those downloaded paths. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: OpenAI Codex:gpt-5
Add CONFIG_LIB_MQTT5_THREAD_STACKSIZE for threads created internally by Paho and use it in Thread.c. Keep CONFIG_UTILS_MQTT5_STACKSIZE scoped to the two utility application tasks. This permits S2OPC to enable MQTT through LIB_MQTT5 without also building unrelated command-line utilities. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: OpenAI Codex:gpt-5
Expose the upstream HIGH_PERFORMANCE mode through CONFIG_LIB_MQTT5_HIGH_PERFORMANCE and enable it by default. This keeps normal embedded builds lightweight while allowing developers to restore Paho heap and call-stack diagnostics when investigating library issues. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: OpenAI Codex:gpt-5
cederom
approved these changes
Aug 22, 2026
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @raiden00pl :-)
simbit18
approved these changes
Aug 22, 2026
acassis
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
dependency for S2OPC
Testing
paho works as dependency for S2OPC and with
CONFIG_UTILS_MQTT5=y