system/readline: restore terminal attributes safely - #3747
Merged
Conversation
Track successful mode changes so failed setup cannot corrupt terminal state. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
cederom
approved these changes
Aug 22, 2026
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @raiden00pl good catch! :-)
xiaoxiang781216
approved these changes
Aug 22, 2026
acassis
approved these changes
Aug 22, 2026
Contributor
Tomek, say good catch to Claude Code first please! :-P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track successful mode changes so failed setup cannot corrupt terminal state.
Impact
Prevents failed termios setup from restoring invalid terminal state
Testing
intel64