fix(core): add MiniMax-M2.7 to regional fallback lists - #5426
Open
octo-patch wants to merge 1 commit into
Open
octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
Generated-by: Codex
Astro-Han
reviewed
Sep 17, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
Thanks — small, focused change. I checked the id against the metadata snapshot, both regional lists, the derived plan list, and the existing guards. No blocking issues; two nits below.
What I verified
- Model id is correct and consistent.
MiniMax-M2.7is an exact key in the models.dev projection for both providers:packages/core/src/model-metadata.generated.ts:586(providerMiniMax) and:595(providerMiniMax-cn), bothlifecycle: "active"withfunctionCalling: true, anddisplayNameMiniMax-M2.7. The PascalCase casing matches its siblings in the same blocks (MiniMax-M2.7-highspeed,MiniMax-M3) and is deliberately not the lowercaseminimax-m2.7form used by the aggregator providers (packages/core/src/provider-registry.ts:367,:386,:412for the Volcengine/Tencent plans). Correct for these two first-party endpoints. - Placement covers both regions symmetrically.
MiniMax(overseas,api.minimax.io,provider-registry.ts:988-992) andMiniMax-cn(domestic,api.minimaxi.com,:1001-1005) both got the same append. - No list is missing. Grepping
MiniMax-M3across the tree, those two are the only hardcoded MiniMax fallback lists. The third MiniMax entry,minimax-coding-plan(provider-registry.ts:823-828), derives its offer from the snapshot viatoolCallingModelIdsand already yieldsMiniMax-M2.7, so it needs no edit — good that the PR didn't hardcode there. - Low blast radius. Appending keeps
fallbackModels[0] === 'MiniMax-M3', which is the new-connection default and the connection-test probe (see the contract comment inpackages/core/src/__tests__/provider-catalog-contract.test.ts:187-190). Stored connections, defaults, and discovery are untouched; only the offline offer grows by one row. - Existing guards still hold.
keeps deprecated snapshot models out of fallback lists(provider-catalog-contract.test.ts:206-217) is satisfied since the id isactive, notdeprecated.
Nits (non-blocking)
MiniMax-cn:MiniMax-M2.7has no pricing row. The generated table hasMiniMax:MiniMax-M2.7(packages/runtime/src/telemetry/model-pricing.generated.ts:401) but zeroMiniMax-cn:*keys; the only China-endpoint row is the hand-written supplementMiniMax-cn:MiniMax-M3atpackages/runtime/src/telemetry/builtin-pricing.ts:74-79. So calls on the new China fallback model will recordcostBasis: 'unpriced'— a handled state, surfaced asunpricedPricingKeyinapps/desktop/src/renderer/application/contracts/session-inspector/session-inspector-panel-model.ts:150— rather than silently mispricing. Optional follow-up: add aMiniMax-cn:MiniMax-M2.7supplement row mirroring the M3 rates, or pick it up in the next generated pricing refresh.- Nothing pins the new entry. The "Tests cover the change and fail without it" box is unchecked, and no test asserts MiniMax fallback contents today. There's a ready-made precedent for exactly this shape of pin — the Moonshot region test at
packages/core/src/__tests__/provider-catalog-contract.test.ts:51-61assertsfallbackModels.includes('kimi-k3'). A two-line analogue (both regions includeMiniMax-M2.7, andfallbackModels[0]remainsMiniMax-M3) would stop a future edit from quietly dropping it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: MiniMax regional fallback model lists omit MiniMax-M2.7.
Summary
Add MiniMax-M2.7 to the global and China MiniMax fallback lists, keeping MiniMax-M3 as the default.
Verification
Passed:
npm ci.npm run lint,npm run format:check,npm run build, andnpm run typecheck.npx knip --workspace apps/desktopandnpx knip --workspace packages/ui.AI use
Tool(s) and scope: Codex prepared the fallback-list edits and ran validation. This is an automated submission.
Checklist
Does this PR entail a change in behavior?